[LTP] [PATCH 1/2] metaparse: Add shell test parser
Petr Vorel
pvorel@suse.cz
Wed Feb 12 15:03:40 CET 2025
Hi Cyril,
Great, thank you!
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Quick notes:
* Implementing help under -h would be a bonus (it segfaults on -h, metadata.c
has it). But this should not block you merging it.
* Please merge with whitespace error
$ make check-metaparse-sh
CHECK metadata/metaparse-sh.c
metaparse-sh.c:90: ERROR: code indent should use tabs where possible
* Resulting JSON has true, 1 instead would be nice. Again, tiny detail.
"vma05.sh": {
"doc": [
"",
"[Description]",
"",
"Regression test if the vsyscall and vdso VMA regions are reported correctly.",
"",
"While [vsyscall] is mostly deprecated with newer systems, there is",
"still plenty of kernels compiled with CONFIG_LEGACY_VSYSCALL_NATIVE and",
"CONFIG_LEGACY_VSYSCALL_EMULATE (see linux/arch/x86/Kconfig for option",
"descriptions). First part of the test will check eligible kernels for",
"regression for a bug fixed by commit 103efcd9aac1 (fix perms/range of",
"vsyscall vma in /proc/*/maps).",
"",
"Second part of test checks [vdso] VMA permissions (fixed with commits",
"b6558c4a2378 (fix [vdso] page permissions) and e5b97dde514f (Add",
"VM_ALWAYSDUMP)). As a consequence of this bug, VMAs were not included",
"in core dumps which resulted in eg. incomplete backtraces and invalid",
"core dump files created by gdb."
],
"needs_root": true,
"needs_tmpdir": true,
"needs_cmds": ["gdb", "uname"],
"save_restore": [
["/proc/sys/kernel/core_pattern", "core", "TBROK"],
["/proc/sys/kernel/core_uses_pid", "0", "TBROK"]
],
"tags": [
["linux-git", "103efcd9aac1"],
["linux-git", "b6558c4a2378"],
["linux-git", "e5b97dde514f"]
],
"fname": "testcases/kernel/mem/vma/vma05.sh"
}
Kind regards,
Petr
More information about the ltp
mailing list