[LTP] [PATCH] ioctl08: Fix comment indentation to fit RST format

Xinjian Ma (Fujitsu) maxj.fnst@fujitsu.com
Thu Feb 20 04:30:06 CET 2025


Hi Andrea

> -----邮件原件-----
> 发件人: Andrea Cervesato <andrea.cervesato@suse.com>
> 发送时间: 2025年2月19日 18:42
> 收件人: Ma, Xinjian/马 新建 <maxj.fnst@fujitsu.com>; ltp@lists.linux.it
> 主题: Re: [LTP] [PATCH] ioctl08: Fix comment indentation to fit RST format
> 
> Hi Ma,
> 
> I really appreciate your work on converting to RST format. I will merge all
> patches having a bullet point list.
> For ordered lists, we can probably use this format, so it will be easier to
> maintain:
> https://sublime-and-sphinx-guide.readthedocs.io/en/latest/lists.html#ordered-li
> sts

It looks good, but I found you have helped merged this patch.
And I have a question, regarding errno test numbers, should we use bullet point lists or ordered lists?
Such as https://lore.kernel.org/ltp/20250219090505.1039462-1-maxj.fnst@fujitsu.com/T/#u
Could you please give some suggestions?

Best regards
Ma

> 
> Please take a look. I will wait for a feedback :-)
> 
> Andrea
> 
> On 2/19/25 11:00, Ma Xinjian via ltp wrote:
> > Signed-off-by: Ma Xinjian <maxj.fnst@fujitsu.com>
> > ---
> >   testcases/kernel/syscalls/ioctl/ioctl08.c | 10 +++++-----
> >   1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/testcases/kernel/syscalls/ioctl/ioctl08.c
> > b/testcases/kernel/syscalls/ioctl/ioctl08.c
> > index 115ad3323..78602f55a 100644
> > --- a/testcases/kernel/syscalls/ioctl/ioctl08.c
> > +++ b/testcases/kernel/syscalls/ioctl/ioctl08.c
> > @@ -9,13 +9,13 @@
> >    * btrfs filesystem.
> >    *
> >    * 1. Sets the same contents for two files and deduplicates it.
> > - *	Deduplicates 3 bytes and set the status to
> > - *	FILE_DEDUPE_RANGE_SAME.
> > + *    Deduplicates 3 bytes and set the status to
> > + *    FILE_DEDUPE_RANGE_SAME.
> >    * 2. Sets different content for two files and tries to
> > - *	deduplicate it. 0 bytes get deduplicated and status is
> > - *	set to FILE_DEDUPE_RANGE_DIFFERS.
> > + *    deduplicate it. 0 bytes get deduplicated and status is
> > + *    set to FILE_DEDUPE_RANGE_DIFFERS.
> >    * 3. Sets same content for two files but sets the length to
> > - *	deduplicate to -1. ioctl(FIDEDUPERANGE) fails with EINVAL.
> > + *    deduplicate to -1. ioctl(FIDEDUPERANGE) fails with EINVAL.
> >    */
> >
> >   #include "config.h"


More information about the ltp mailing list