[LTP] [PATCH] syscalls/getrusage04: Disable for VIRT_OTHER

[Martin Doucha]

Hi,
I think it'd be better to change the condition to this:

if (tst_is_virt(VIRT_ANY))
     tst_brkm(TCONF, ...);

Otherwise we'll play endless whack-a-mole with future virt environments.

On 24. 02. 25 17:26, Ricardo B. Marlière wrote:
> From: Ricardo B. Marlière <rbm@suse.com>
> 
> This test is known to be unstable under some environments such as in the
> context of a cloud instance within AWS (and other providers as well), which
> outputs "amazon" for `systemd-detect-virt` and therefore falls into the
> VIRT_OTHER category.
> 
> Suggested-by: Martin Doucha <mdoucha@suse.cz>
> Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
> ---
>   testcases/kernel/syscalls/getrusage/getrusage04.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/getrusage/getrusage04.c b/testcases/kernel/syscalls/getrusage/getrusage04.c
> index b03bc549bd835b33acaa02693706255e88cbe4f8..0e22e2ee9dadfb1c05df4425c65b04b2579e1649 100644
> --- a/testcases/kernel/syscalls/getrusage/getrusage04.c
> +++ b/testcases/kernel/syscalls/getrusage/getrusage04.c
> @@ -198,9 +198,11 @@ static void setup(void)
>   {
>   	tst_sig(NOFORK, DEF_HANDLER, cleanup);
>   
> -	if (tst_is_virt(VIRT_XEN) || tst_is_virt(VIRT_KVM) || tst_is_virt(VIRT_HYPERV))
> -		tst_brkm(TCONF, NULL, "This testcase is not supported on this"
> -		        " virtual machine.");
> +	if (tst_is_virt(VIRT_XEN) || tst_is_virt(VIRT_KVM) ||
> +	    tst_is_virt(VIRT_HYPERV) || tst_is_virt(VIRT_OTHER))
> +		tst_brkm(TCONF, NULL,
> +			 "This testcase is not supported on this"
> +			 " virtual machine.");
>   
>   	BIAS_MAX = guess_timer_resolution();
>   
> 
> ---
> base-commit: a1aebfd4d99d5da12834dae5215815ff8d82995c
> change-id: 20250224-disable_virt_other_getrusage04-c9db2aa9e69c
> 
> Best regards,


-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic