[LTP] [PATCH v2] syscalls/getrusage04: Disable for VIRT_ANY
Martin Doucha
mdoucha@suse.cz
Tue Feb 25 17:18:57 CET 2025
Hi,
the commit message is inaccurate because the test will get disabled on
all detected virt environments. But the patch looks good.
Reviewed-by: Martin Doucha <mdoucha@suse.cz>
On 25. 02. 25 17:11, Ricardo B. Marlière wrote:
> From: Ricardo B. Marlière <rbm@suse.com>
>
> This test is known to be unstable under some virtualized environments,
> therefore only allow it for recognized ones.
>
> Suggested-by: Martin Doucha <mdoucha@suse.cz>
> Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
> ---
> Changes in v2:
> - Use VIRT_ANY instead of VIRT_OTHER for future proofing
> - Link to v1: https://lore.kernel.org/r/20250224-disable_virt_other_getrusage04-v1-1-bcb433af9635@suse.com
> ---
> testcases/kernel/syscalls/getrusage/getrusage04.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/getrusage/getrusage04.c b/testcases/kernel/syscalls/getrusage/getrusage04.c
> index b03bc549bd835b33acaa02693706255e88cbe4f8..983db2649690e4318b62ce3340192102cb1dacf4 100644
> --- a/testcases/kernel/syscalls/getrusage/getrusage04.c
> +++ b/testcases/kernel/syscalls/getrusage/getrusage04.c
> @@ -198,9 +198,10 @@ static void setup(void)
> {
> tst_sig(NOFORK, DEF_HANDLER, cleanup);
>
> - if (tst_is_virt(VIRT_XEN) || tst_is_virt(VIRT_KVM) || tst_is_virt(VIRT_HYPERV))
> - tst_brkm(TCONF, NULL, "This testcase is not supported on this"
> - " virtual machine.");
> + if (tst_is_virt(VIRT_ANY))
> + tst_brkm(TCONF, NULL,
> + "This testcase is not supported on this"
> + " virtual machine.");
>
> BIAS_MAX = guess_timer_resolution();
>
>
> ---
> base-commit: a1aebfd4d99d5da12834dae5215815ff8d82995c
> change-id: 20250224-disable_virt_other_getrusage04-c9db2aa9e69c
>
> Best regards,
--
Martin Doucha mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
More information about the ltp
mailing list