[LTP] [PATCH v2 1/2] lib: Add helpers for module signature enforcement

[Li Wang]

Petr Vorel <pvorel@suse.cz> wrote:


> +/**
> + * tst_check_module_signature_enforced() - Check if test needs to be
> skipped due
> + * enforced module signature.
> + *
> + * Skip test with tst_brk(TCONF) due module signature enforcement if
> + * module.sig_enforce=1 kernel parameter or CONFIG_MODULE_SIG_FORCE=y.
> + */
> +
> +static inline void tst_check_module_signature_enforced(void)
>

This function is used to skip tests while detecting the signature
enforcement ON, but the name might be ambiguous somewhere.

I would suggest to name it:

  tst_check_module_signature_not_enforced(void)  or,
  tst_skip_if_module_signature_enforced(void)  or,
  tst_requires_module_signature_disabled(void)

Otherwise, the whole patch set looks good.

Reviewed-by: Li Wang <liwang@redhat.com>


-- 
Regards,
Li Wang