[LTP] [PATCH v2 6/6] mem/vma05.sh: Convert to the new shell library
Cyril Hrubis
chrubis@suse.cz
Mon Jan 6 17:32:36 CET 2025
Hi!
As for the minor adjustements I will fix them before merge if the
patchset gets accepted.
> I wonder how hard to add shell support (with help of ujson) to metadata/metaparse.c.
>
> I created a ticket for it:
> https://github.com/linux-test-project/ltp/issues/1216
The metadata are in the right format already, so the extraction will be
easy. I've commented that issue and asigned it to myself.
> > +# ]
> > +# }
> > +# ---
>
> We don't need setup and cleanup at all. But I see we don't have a support for
> them in testcases/lib/tst_run_shell.c yet. I might need to add it for
> netstress.c.
I will look into that later on. In this case we have to repeate the
ulimit and unset on each test iteration because the shell script is
re-executed for each -i value. So setup and cleanup are only useful for
things that outlive the shell script itself e.g. starting and stopping a
NFS sever.
> ...
>
> FYI testcases/lib/tests/shell_loader*.sh would deserve SPDX and copyright.
I guess that I will just commit this as an obvius fix.
--
Cyril Hrubis
chrubis@suse.cz
More information about the ltp
mailing list