[LTP] [PATCH 1/1] runtest/ltp-aiodio.part4: Remove duplicate entries

[Andrea Cervesato]

Hi Cyril,

On 1/7/25 11:43, Cyril Hrubis wrote:
> Hi!
>> @Cyril? If relevant maybe we should just document it. Does it apply to all
>> duplicates? I wonder if it makes sense to run whole runset for 45 min when we
>> are testing something mainline does not care about it's performance.
> Well the ltp-aiodio.part4 is a stress test that iterates between
> different I/O stress tests. Stress tests by definition must run for some
> time to be useful, the question is for how long these should be run and
> for that there is no clear answer I'm afraid.
>
> The dirty and dio_sparse are interleaved because dirty tries to fill in
> the page cache with dirty pages before each dio_sparse iteration. The
> dio_sparse then creates a sparse file and checks that we correctly read
> zeroes all the time while other processes write zeroes to the sparse
> file. It may make sense to merge the dirty.c into the dio_sparse.c so
> that it's executed at the start of the test and then possibly eliminate
> one block of the dio_sparse tests.
>
> We may as well get rid of the multiple lines in the runtest file by
> passing -i option since these tests were converted into the new test
> library. But over all I wouldn't vote for reducing the runtime for these
> tests as drastically as you proposed.
>
I agree with everything. The usage of runtest file for something 
strictly related to ltp-aiodio.part4 doesn't sound right.
We need to get rid of "dirty" binary and include it inside the test.

Andrea