[LTP] [PATCH v2 09/11] Refactor pty01 test

Andrea Cervesato andrea.cervesato@suse.com
Thu Jan 9 09:28:51 CET 2025


Hi Petr,

On 1/8/25 13:39, Petr Vorel wrote:
>> +	SAFE_STAT(slavename, &st);
>> +	TST_EXP_EQ_LI(st.st_uid, getuid());
>> +
>> +	/* grantpt() is a no-op in bionic. */
>>   #ifndef __BIONIC__
>> -	if (st.st_mode != (S_IFCHR | S_IRUSR | S_IWUSR | S_IWGRP)) {
>> -		tst_brkm(TBROK, NULL, "mode mismatch (mode=%o)", st.st_mode);
>> -	}
>> +	TST_EXP_EQ_LI(st.st_mode, 0620);
> Here it continues testing, does it makes sense? Previously it quit with
> tst_brkm().

I'm not even sure if the check makes sense...do you have any idea?

Andrea


More information about the ltp mailing list