[LTP] [PATCH] lib/tst_kconfig: Include stddef.h

Ricardo B. Marliere rbm@suse.com
Tue Jan 14 14:18:01 CET 2025


Hi Petr!

On 14 Jan 25 03:55, Petr Vorel wrote:
> Hi Ricardo,
> 
> > Currently, if a test wants to make use of tst_kconfig.h it must also
> > include stddef.h due to the usage of size_t. While at it, fix a few minor
> 
> <stddef.h> or <stdlib.h>
> 
> Good catch, it should be corrected.
> 
> <stdlib.h> is used in lib/tst_test.c, thus tests have it for free,
> but there are libraries, which load it as well.
> 
> > typos in comments.
> 
> FYI we usually split changes into commits (easier in case of revert),
> but this is, of course, OK to keep.

I'm aware, but when I was about to send I noticed these and figured it
wouldn't hurt to bundle them in :)

> 
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> Also, I wondered if we want to remove these includes in files they use
> tst_kconfig.h, but probably not necessary.

I'll do some quick grepping to investigate.

Thanks for reviewing,
-	Ricardo.


> 
> Kind regards,
> Petr
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp


More information about the ltp mailing list