[LTP] [PATCH] .b4-config: Add checkpatch.pl default commands
Andrea Cervesato
andrea.cervesato@suse.com
Wed Jan 15 12:03:48 CET 2025
Hi,
On 1/15/25 11:44, Ricardo B. Marliere wrote:
> Hi Andrea!
>
> On Wed, Jan 15, 2025 at 09:54:43AM +0100, Andrea Cervesato wrote:
>> Hi,
>>
>> thanks for this patch. I was using something similar, but the output here
>> seems more reliable. What I don't really understand is the following error
>> for many of the commits in the patch-set:
> What patch-set are you referring to?
I was referring to the current patch-set under development in b4 branch.
>
>> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> I remember seeing those in the past, but was unable to see it when
> running against the last patch-set I sent (regarding mmap refactors).
> I'm running b4 version 0.14.2.
>
> Replying to your other message: I agree with adding FILE_PATH_CHANGES to
> the ignores, since there is no MAINTAINERS file in LTP. That should also
> probably be added to include/mk/env_post.mk.
Yeah I was thinking that. I will submit this patch with a change on
env_post.mk as well.
>
> Thank you,
> - Ricardo.
>
>
>> Andrea
>>
>> On 1/14/25 23:43, Ricardo B. Marliere via ltp wrote:
>>> From: Ricardo B. Marliere <rbm@suse.com>
>>>
>>> Blend b4 default checkpatch.pl flags with the ones defined in
>>> include/mk/env_post.mk in .b4-config so that a contributor may use `b4 prep
>>> --check` and `b4 am --check` in his workflow.
>>>
>>> Signed-off-by: Ricardo B. Marliere <rbm@suse.com>
>>> ---
>>> .b4-config | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/.b4-config b/.b4-config
>>> index 2efdf2273240dcf57bd5cab174ff6c7a1952dd5b..5a16bd64ec98b91e17386c0eadc7ef0de54d86f3 100644
>>> --- a/.b4-config
>>> +++ b/.b4-config
>>> @@ -4,3 +4,6 @@
>>> send-series-to = Linux Test Project <ltp@lists.linux.it>
>>> pw-url = https://patchwork.ozlabs.org/
>>> pw-project = ltp
>>> + prep-perpatch-check-cmd = ./scripts/checkpatch.pl -q --terse --no-summary --mailback --showfile --no-tree --ignore CONST_STRUCT,VOLATILE,SPLIT_STRING
>>> + am-perpatch-check-cmd = ./scripts/checkpatch.pl -q --terse --no-summary --mailback --no-tree --ignore CONST_STRUCT,VOLATILE,SPLIT_STRING
>>> +
>>>
>>> ---
>>> base-commit: 6fe8aa186559784f0394cd449cba6c53342790ec
>>> change-id: 20250114-fix_b4-config-1ab84320000a
>>>
>>> Best regards,
Thanks,
Andrea
More information about the ltp
mailing list