[LTP] [PATCH v2 1/1] lib: Multiply slow config only for a real tests

Cyril Hrubis chrubis@suse.cz
Fri Jan 17 11:31:49 CET 2025


Hi!
> > diff --git a/testcases/lib/tst_ns_exec.c b/testcases/lib/tst_ns_exec.c
> > index 6a8e39339..989bb8910 100644
> > --- a/testcases/lib/tst_ns_exec.c
> > +++ b/testcases/lib/tst_ns_exec.c
> > @@ -100,7 +100,12 @@ int main(int argc, char *argv[])
> >         for (i = 0; i < ns_fds; i++)
> >                 SAFE_SETNS(ns_fd[i], 0);
> 
> > -       pid = SAFE_CLONE(&args);
> > +       pid = tst_clone(&args);
> > +       if (pid < 0) {
> > +               printf("clone() failed");
> > +               return 1;
> > +       }
> > +
> >         if (!pid)
> >                 SAFE_EXECVP(argv[3], argv+3);
> 
> Thanks, it works! Could you please merge it? Maybe update the comment?
> 
> -       .forks_child = 1, /* Needed by SAFE_CLONE */
> +       .forks_child = 1, /* Needed by safe_clone() */

I guess that we do not need that one anymore. Does the helper work if
we remove it?

> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Fixes: 893ca0abe7 ("lib: multiply the timeout if detect slow kconfigs")

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list