[LTP] [PATCH v7 2/2] ptrace06: Refactor the test using new LTP API

Petr Vorel pvorel@suse.cz
Fri Jan 17 12:12:21 CET 2025


> Hi!
> > > +/*
> > > + * Copyright (c) 2018 Linux Test Project
> > > + * Copyright (C) 2015 Cyril Hrubis chrubis@suse.cz
> > > + */
> > > +
> > > +#define TST_NO_DEFAULT_MAIN
> > > +#include "tst_test.h"
> > > +
> > > +int main(int argc, char *argv[])

> > ptrace06_child.c:10:14: warning: unused parameter ‘argc’ [-Wunused-parameter]
> >    10 | int main(int argc, char *argv[])

> > > +{
> > > +
> > nit: empty line ^
> > > +	tst_res(TPASS, "%s executed", argv[0]);
> > > +
> > > +	return 0;
> > > +}

> > I suggest to merge the patchset with this change in this commit.

> > @Cyril: Can I add your RBT?

> Have you seen my review? That file is not used at all. And also the
> TEST() statement in the actual test.

I'm sorry I overlooked it. First commit is merged with your RBT.
And I'm sorry not catching these.

For this patch I ptrace06_child.c and merged. But because there is TEST(ptrace,
...  left, I dared to removed it again (with git push -f), Wei please send
another version (I guess without my RBT as the code changed a lot since I add
the tag).

Kind regards,
Petr


More information about the ltp mailing list