[LTP] [PATCH] eventfd06: add AIO support check

Petr Vorel pvorel@suse.cz
Tue Jan 21 12:13:51 CET 2025


Hi Li,
...
> > > +     if (TST_RET == -ENOSYS)

> > Reviewed-by: Petr Vorel <pvorel@suse.cz>

> > Maybe to be safe to check also TST_RET?

> > if (TST_RET == -1 && TTERRNO == ENOSYS)

> I guess you mean: if (TST_RET == -1 &&  TST_ERR == ENOSYS).

> Typically this is correct but here it's not right. Because according
> to the io_setup(2) - Linux man page:

> "... Note also that the libaio wrapper does not follow the
> usual C library conventions for indicating errors: on
> error it returns a negated error number (the negative
> of one of the values listed in ERRORS) ... "

Ah, I'm sorry, I overlooked that.
I guess Cyril will ack this obvious fix today.

Kind regards,
Petr


More information about the ltp mailing list