[LTP] [PATCH] cgroup_regression_test: Use unique names for hierarchies in each test

[Martin Doucha]

On 30. 07. 25 13:32, Avinesh Kumar wrote:
> Hi all¸
> 
> I would like to ask if there are any other suggestions on how to address this
> issue.
> I tried a rather simpler approach (as suggested by Martin) of just adding a
> delay using sleep after the umount call, which also seems to solve this issue
> of incomplete unmounting.
> 
> --- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> +++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> @@ -102,10 +102,11 @@ test1()
>          cat cgroup/tasks > /dev/null
>   
>          kill -TERM $!
>          wait $! 2>/dev/null
>          umount cgroup/
> +       sleep 2
>          check_kernel_bug
>   }
> 
> I will send this in the patch if we agree to use this approach instead of
> unique names.

Well, this looks like the unmount happens asynchronously and the command 
exits before it's actually finished. In that case, sync would be the 
best solution. But I think we need some feedback from kernel developers 
whether the asynchronous behavior is intentional or not. Should the 
umount command wait for the task to finish?

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic