[LTP] [PATCH v4 3/8] syscalls/mknod03: Convert to new API

Petr Vorel pvorel@suse.cz
Thu Jun 5 09:32:31 CEST 2025


Hi Ricardo, Andrea,

...
> +/*\
> + * Verify that mknod(2) succeeds when used to create a filesystem node with
> + * set-group-ID bit set on a directory with set-group-ID bit set. The node
> + * created should have set-group-ID bit set and its gid should be equal to
> + * the "nobody" gid.
>   */

> -#define MODE_RWX	S_IFIFO | S_IRWXU | S_IRWXG | S_IRWXO
> -#define MODE_SGID       S_IFIFO | S_ISGID | S_IRWXU | S_IRWXG | S_IRWXO
...
> +#define MODE_RWX 0777
> +#define MODE_SGID (S_ISGID | 0777)

And here also dropped S_IFIFO. Did I overlook a discussion that mknod() can be
called without S_IFIFO? (I don't think so).

And old tests use S_IFIFO also for mkdir(), but that is IMHO not needed.

Kind regards,
Petr


More information about the ltp mailing list