[LTP] [PATCH v5 1/8] syscalls/mknod01: Fix checkpatch.pl warnings
Ricardo B. Marlière
rbm@suse.com
Thu Jun 5 14:52:17 CEST 2025
From: Ricardo B. Marlière <rbm@suse.com>
Fix the following warnings:
Alignment should match open parenthesis
Please don't use multiple blank lines
Also, fix 32b compat mode warning:
mknod01.c:37:22: warning: format ‘%ld’ expects argument of type ‘long int’,
but argument 6 has type ‘dev_t’
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>
Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
---
testcases/kernel/syscalls/mknod/mknod01.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/testcases/kernel/syscalls/mknod/mknod01.c b/testcases/kernel/syscalls/mknod/mknod01.c
index fe0a1cfa6a473f9c2b2a55493f830f13b86560a8..801d2ef2a3394793c7cb4bbe63bc4fea15bb4ec3 100644
--- a/testcases/kernel/syscalls/mknod/mknod01.c
+++ b/testcases/kernel/syscalls/mknod/mknod01.c
@@ -10,6 +10,8 @@
* various modes.
*/
+#include <inttypes.h>
+#include <stdint.h>
#include <sys/sysmacros.h>
#include "tst_test.h"
@@ -26,7 +28,6 @@ static int tcases[] = {
S_IFREG | 06700,
};
-
static void run(unsigned int i)
{
dev_t dev = 0;
@@ -35,8 +36,8 @@ static void run(unsigned int i)
dev = makedev(1, 3);
TST_EXP_PASS(mknod(PATH, tcases[i], dev),
- "mknod(PATH, %o, %ld)",
- tcases[i], dev);
+ "mknod(PATH, %o, %ju)",
+ tcases[i], (uintmax_t)dev);
SAFE_UNLINK(PATH);
}
--
2.49.0
More information about the ltp
mailing list