[LTP] [PATCH 0/3] checkpoint: Refactor and unify shell/C reinit support

[Li Wang]

On Fri, Jun 27, 2025 at 6:43 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> Hi!
> > > > So, will you send a new patch (or I do that in my next version)?
> > >
> > > I will send the patchset.
> > >
> >
> > Thanks! And one more question:
> >
> > The tst_checkpoint_init() in tst_checkpoint.c is not used by any test
> > and library, should we delete it (and declare that the IPC only
> init/reinit
> > by the tst_test.c function)?
>
> There is actually a define to TST_CHECKPOINT_INIT in the
> include/old/old_checkpoint.h but it looks like the last parts where this
> is called are old library tests that should be removed along with that.
>
> And the last test that was using it before rewrite was:
>
> commit b043751a6984c41db61067eebb0fee6ebf303960
> Author: Andrea Cervesato <andrea.cervesato@suse.de>
> Date:   Fri Mar 25 13:54:43 2022 +0100
>
>     Rewrite shm_comm.c using new LTP API
>
>     Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.de>
>     Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
>
>
> So yes please, let's get rid of it. We should have do so actually three
> years ago.
>

True, that became a noise factor in reading the checkpoint code,
and yes, I will send a patch to clean it up.

-- 
Regards,
Li Wang