[LTP] [PATCH v4 2/8] Refactor mmap10 test

[Cyril Hrubis]

Hi!
> +	struct tcase *tc = &tcases[i];
> +	int fd = -1;
>  
> -	if (opt_ksm) {
> +	if (tc->add_ksm) {
>  		if (access(PATH_KSM, F_OK) == -1)
> -			tst_brkm(TCONF, NULL,
> -				 "KSM configuration is not enabled");
> -#ifdef HAVE_DECL_MADV_MERGEABLE
> -		tst_resm(TINFO, "add to KSM regions.");
> -#else
> -		tst_brkm(TCONF, NULL, "MADV_MERGEABLE missing in sys/mman.h");
> -#endif
> +			tst_brk(TCONF, "KSM configuration is not enabled");
> +	} else {
> +		tst_res(TINFO, "Add to KSM regions");

This else looks like it's for wrong if, shouldn't this be the else for
the inner if?

The rest looks good. With that else branch fixed:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz