[LTP] [PATCH v4 8/8] Refactor mmap001 test and move it to mmap21

[Cyril Hrubis]

Hi!
> +	SAFE_LSEEK(fd, 0, SEEK_SET);
> +	SAFE_READ(0, fd, buff, memory_size);
> +	SAFE_CLOSE(fd);
> +
> +	for (int i = 0; i < memory_size; i++) {
> +		if (buff[i] != (char)i) {
> +			tst_res(TFAIL, "Mapped file has not been updated at byte %d", i);
> +			goto exit;
> +		}
> +	}
> +
> +	tst_res(TPASS, "Mapped file has been updated");
> +
> +exit:
> +	SAFE_MUNMAP(memory_data, memory_size);

Here we miss:

	memory_data = NULL;


So that we do not attempt to unmap it again if SAFE_UNLINK() has failed.

> +	SAFE_UNLINK(FILE_NAME);
> +}
> +
> +static void setup(void)
> +{
> +	if (tst_parse_filesize(str_pages, &pages, 1, LLONG_MAX))
> +		tst_brk(TBROK, "Invalid number of pages: %s", str_pages);
> +
> +	memory_size = pages * getpagesize();
> +
> +	buff = SAFE_MALLOC(memory_size);
> +}

The rest looks good:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz