[LTP] [PATCH v2] syscalls/mknod03: Convert to new API

[Andrea Cervesato]

Hi Ricardo,

On 3/21/25 11:00, Ricardo B. Marliere via ltp wrote:
> -		/*
> -		 * Skip S_ISGID check
> -		 * 0fa3ecd87848 ("Fix up non-directory creation in SGID directories")
> -		 * clears S_ISGID for files created by non-group members
> -		 */
> +	SAFE_SETGID(nobody_gid);
> +	SAFE_SETREUID(-1, nobody_uid);
I have the feeling that setting gid/uid for the current process doesn't 
make much sense now,
because we are only testing if mknod() is correctly setting set-group-ID 
bit according to its parent folder.
Once we setup the parent folder, we should already have the right result 
at the end if mknod() works properly.

I will leave the rest of the review to @Petr Vorel :-)

The rest LGTM.

Kind regards,
Andrea Cervesato