[LTP] [PATCH 4/4] syscalls/modify_ldt: Refactor modify_ldt01 into new API

[Ricardo B. Marlière]

Hi Andrea,

On Tue Mar 25, 2025 at 7:10 AM -03, Andrea Cervesato wrote:
> Hi!
>
> So this is a test which is testing if modify_ldt syscall is producing 
> the right errors according to invalid inputs. It's a pretty common type 
> of test in LTP and we can extend it to all the other errors as well 
> Basically, we need to merge simple tests checking for errors into a 
> single one using test cases.

So, basically keep 01 and extend it instead of splitting it into new
tests such as 04 and 05?

>
> Some comments below.
>
> On 3/24/25 21:45, Ricardo B. Marliere via ltp wrote:
>> From: Ricardo B. Marlière <rbm@suse.com>
>>
>> Also split its three blocks into individual tests.
>>
>> Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
>> ---
>>   testcases/kernel/syscalls/modify_ldt/.gitignore    |   8 +-
>>   .../kernel/syscalls/modify_ldt/modify_ldt01.c      | 234 ++-------------------
>>   .../kernel/syscalls/modify_ldt/modify_ldt04.c      |  32 +++
>>   .../kernel/syscalls/modify_ldt/modify_ldt05.c      |  37 ++++
>>   4 files changed, 92 insertions(+), 219 deletions(-)
>>
>> diff --git a/testcases/kernel/syscalls/modify_ldt/.gitignore b/testcases/kernel/syscalls/modify_ldt/.gitignore
>> index c0b8bbf5875af453b4880ef4b717fdb40d109ee7..76fe2f3f0592f92fa87963597d0c03e2fd81e2da 100644
>> --- a/testcases/kernel/syscalls/modify_ldt/.gitignore
>> +++ b/testcases/kernel/syscalls/modify_ldt/.gitignore
>> @@ -1,3 +1,5 @@
>> -/modify_ldt01
>> -/modify_ldt02
>> -/modify_ldt03
>> +modify_ldt01
>> +modify_ldt02
>> +modify_ldt03
>> +modify_ldt04
>> +modify_ldt05
>> diff --git a/testcases/kernel/syscalls/modify_ldt/modify_ldt01.c b/testcases/kernel/syscalls/modify_ldt/modify_ldt01.c
>> index 684e53772414ae468b4f168578596eabb27ef18b..45e9649f91b68f28c8adc081183cfbd1b1c3ca88 100644
>> --- a/testcases/kernel/syscalls/modify_ldt/modify_ldt01.c
>> +++ b/testcases/kernel/syscalls/modify_ldt/modify_ldt01.c
>> @@ -1,230 +1,32 @@

<snip>

>> -void cleanup(void)
>> +void run(void)
>>   {
>> +	char buf[sizeof(struct user_desc)];
>>   
>> +	TEST(modify_ldt(100, buf, sizeof(buf)));
>> +	TST_EXP_EQ_LI(TST_ERR, ENOSYS);
>
> We can use TST_EXP_FAIL() which is a shorter version.
>
> Also, when we are testing syscalls, we usually (not always for 
> historical reasons) use guarded buffers for memory input. Please take a 
> look at the "tst_test::bufs" attribute. Also in this case, LTP code is 
> the way to understand how to use them.

I'll take a look at that, thanks for the pointers.

> Kind regards,
> Andrea Cervesato

Thanks for reviewing,
-	Ricardo.