[LTP] [PATCH 2/2] dirtyc0w_shmem: set child_needs_reinit

[Li Wang]

On Tue, May 13, 2025 at 4:32 PM Wei Gao <wegao@suse.com> wrote:

> On Tue, May 13, 2025 at 01:05:30PM +0800, Li Wang wrote:
> > Signed-off-by: Li Wang <liwang@redhat.com>
> > ---
> >  testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c
> b/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c
> > index 64b187b35..4b31da831 100644
> > --- a/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c
> > +++ b/testcases/kernel/security/dirtyc0w_shmem/dirtyc0w_shmem.c
> > @@ -104,6 +104,7 @@ static void cleanup(void)
> >
> >  static struct tst_test test = {
> >       .needs_checkpoints = 1,
> > +     .child_needs_reinit =1 ,
> s/.child_needs_reinit =1 ,/.child_needs_reinit = 1,/
>

Good catch. That blank before the comma should be removed.


> Do we still need this? Since .needs_checkpoints is already setted.
>

I think yes!

While some fields may have overlapping effects, explicitly setting this
field
highlights its intended function and enhances the clarity of the code.


-- 
Regards,
Li Wang