[LTP] [PATCH v4 2/8] syscalls/mknod02: Use relative path to avoid use of SAFE_CHDIR

Andrea Cervesato andrea.cervesato@suse.com
Tue May 20 14:46:35 CEST 2025


Hi!

Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>

On 4/25/25 20:06, Ricardo B. Marlière via ltp wrote:
> From: Ricardo B. Marlière <rbm@suse.com>
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
> ---
>   testcases/kernel/syscalls/mknod/mknod02.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/mknod/mknod02.c b/testcases/kernel/syscalls/mknod/mknod02.c
> index 89dd1d8740234b788554e625e693693b954440cc..bd476fff79cdde9073dd49664f6fd32031f9d966 100644
> --- a/testcases/kernel/syscalls/mknod/mknod02.c
> +++ b/testcases/kernel/syscalls/mknod/mknod02.c
> @@ -20,7 +20,7 @@
>   #define MODE_SGID	02000
>   
>   #define TEMP_DIR "testdir"
> -#define TEMP_NODE "testnode"
> +#define TEMP_NODE TEMP_DIR "/testnode"
>   
>   static struct stat buf;
>   static struct passwd *user_nobody;
> @@ -37,14 +37,12 @@ static void setup(void)
>   
>   static void run(void)
>   {
> -	SAFE_CHDIR(TEMP_DIR);
>   	TST_EXP_PASS(mknod(TEMP_NODE, MODE1, 0), "mknod(%s, %o, 0)", TEMP_NODE, MODE1);
>   
>   	SAFE_STAT(TEMP_NODE, &buf);
>   	TST_EXP_EQ_LI(buf.st_gid, 0);
>   
>   	SAFE_UNLINK(TEMP_NODE);
> -	SAFE_CHDIR("..");
>   }
>   
>   static struct tst_test test = {
>


More information about the ltp mailing list