[LTP] [PATCH v3 1/2] tst_filesystems01.c: Add test for .filesystems

[Wei Gao]

On Wed, Nov 12, 2025 at 01:21:26PM +0100, Petr Vorel wrote:
> > Hi!
> > > > > > +static void do_test(void)
> > > > > > +{
> > > > > > +	long fs_type;
> > > > > > +
> > > > > > +	fs_type = tst_fs_type(MOUNT_POINT);
> > > > > > +
> > > > > > +	if (fs_type == TST_EXT234_MAGIC) {
> > > > > > +		TST_EXP_PASS((check_inode_size(128)));
> > > > > > +		TST_EXP_PASS((check_mkfs_size_opt(10240)));
> 
> > > > > very nit: I would personally add #define for 128 and 10240, but sure it's ok to
> > > > > keep it hardcoded on 2 places.
> > > > I thought also use #define but i found and can not replace it in
> > > > "mkfs_opts = (const char *const []){"-I", "128", "-b", "1024", NULL}",
> > > > so i keep hardcoded number here.
> 
> > > Thanks for info. Sure, no problem.
> 
> > > Cc Cyril in case it's worth to fix it in metaparse.c.
> 
> > The metaparse tool does macro expansion, that shouldn't be a problem.
> 
> > Also metaparse only scans testcases/ directory during the build. The
> > lib/ directory is not parsed at all.
> 
> @Cyril Ah, I'm sorry I forget it's a library test, not an ordinary test.
> 
> @Wei I thought tested and see the problem, but you probably just suspect it
> would be a problem.
Sorry i have not deep checked, since i put "INODE_SIZE" into mkfs_opts and
error report so i guess it not support it.
> 
> Kind regards,
> Petr