[LTP] [PATCH] [PATCH 3/3] [PATCH] Migrating the libhugetlbfs/testcases/straddle_4GB.c v3
Pavithra
pavrampu@linux.ibm.com
Sun Nov 30 06:13:31 CET 2025
Changes in v3:
- Removed [Description] line
- Replaced mmap(2) with :man2:`mmap`
- Used TST_GB inplace of FOURGB
- Added tst_brk incase of statfs64 failure
- Replaced munmap with SAFE_MUNMAP
- Modified print messages based on review comments
- Added check for hpage_size
Signed-off-by: Pavithra <pavrampu@linux.ibm.com>
---
runtest/hugetlb | 1 +
testcases/kernel/mem/.gitignore | 1 +
.../kernel/mem/hugetlb/hugemmap/Makefile | 1 +
.../kernel/mem/hugetlb/hugemmap/hugemmap40.c | 155 ++++++++++++++++++
4 files changed, 158 insertions(+)
create mode 100644 testcases/kernel/mem/hugetlb/hugemmap/hugemmap40.c
diff --git a/runtest/hugetlb b/runtest/hugetlb
index 0896d3c94..8124ba3e5 100644
--- a/runtest/hugetlb
+++ b/runtest/hugetlb
@@ -36,6 +36,7 @@ hugemmap30 hugemmap30
hugemmap31 hugemmap31
hugemmap32 hugemmap32
hugemmap34 hugemmap34
+hugemmap40 hugemmap40
hugemmap05_1 hugemmap05 -m
hugemmap05_2 hugemmap05 -s
hugemmap05_3 hugemmap05 -s -m
diff --git a/testcases/kernel/mem/.gitignore b/testcases/kernel/mem/.gitignore
index b4455de51..314396274 100644
--- a/testcases/kernel/mem/.gitignore
+++ b/testcases/kernel/mem/.gitignore
@@ -36,6 +36,7 @@
/hugetlb/hugemmap/hugemmap31
/hugetlb/hugemmap/hugemmap32
/hugetlb/hugemmap/hugemmap34
+/hugetlb/hugemmap/hugemmap40
/hugetlb/hugeshmat/hugeshmat01
/hugetlb/hugeshmat/hugeshmat02
/hugetlb/hugeshmat/hugeshmat03
diff --git a/testcases/kernel/mem/hugetlb/hugemmap/Makefile b/testcases/kernel/mem/hugetlb/hugemmap/Makefile
index 6e72e7009..a1711f978 100644
--- a/testcases/kernel/mem/hugetlb/hugemmap/Makefile
+++ b/testcases/kernel/mem/hugetlb/hugemmap/Makefile
@@ -12,3 +12,4 @@ CFLAGS_no_stack_prot := $(filter-out -fstack-clash-protection, $(CFLAGS))
hugemmap06: CFLAGS+=-pthread
hugemmap34: CFLAGS=$(CFLAGS_no_stack_prot)
+hugemmap40: CFLAGS += -D_LARGEFILE64_SOURCE
diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap40.c b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap40.c
new file mode 100644
index 000000000..01ba0c316
--- /dev/null
+++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap40.c
@@ -0,0 +1,155 @@
+// SPDX-License-Identifier: LGPL-2.1-or-later
+/*
+ * Copyright (C) 2005-2006 David Gibson & Adam Litke, IBM Corporation.
+ * Copyright (C) 2006 Hugh Dickins <hugh@veritas.com>
+ */
+
+/*\
+ *
+ * Test tries to allocate hugepages to cover a memory range that straddles the
+ * 4GB boundary, using :man2:`mmap` with and without MAP_FIXED.
+ */
+
+#define MAPS_BUF_SZ 4096
+#define MNTPOINT "hugetlbfs/"
+
+#include "hugetlb.h"
+
+static long hpage_size;
+static int fd = -1;
+static unsigned long straddle_addr;
+
+static int test_addr_huge(void *p)
+{
+ char name[256];
+ char *dirend;
+ int ret;
+ struct statfs64 sb;
+
+ ret = read_maps((unsigned long)p, name);
+ if (ret < 0)
+ return ret;
+
+ if (ret == 0) {
+ tst_res(TINFO, "Couldn't find address %p in /proc/self/maps", p);
+ return -1;
+ }
+
+ /* looks like a filename? */
+ if (name[0] != '/')
+ return 0;
+
+ /* Truncate the filename portion */
+ dirend = strrchr(name, '/');
+ if (dirend && dirend > name)
+ *dirend = '\0';
+
+ ret = statfs64(name, &sb);
+ if (ret)
+ tst_brk(TBROK | TERRNO, "statfs check on filesystem failed");
+
+ return (sb.f_type == HUGETLBFS_MAGIC);
+}
+
+static void run_test(void)
+{
+ void *p;
+
+ /* We first try to get the mapping without MAP_FIXED */
+ tst_res(TINFO, "Mapping without MAP_FIXED at %lx...", straddle_addr);
+ p = mmap((void *)straddle_addr, 2*hpage_size, PROT_READ|PROT_WRITE,
+ MAP_SHARED, fd, 0);
+ if (p == (void *)straddle_addr) {
+ /* These tests irrelevant if we didn't get the straddle address*/
+ if (test_addr_huge(p) != 1) {
+ tst_res(TFAIL, "1st Mapped address is not hugepage");
+ goto windup;
+ }
+ if (test_addr_huge(p + hpage_size) != 1) {
+ tst_res(TFAIL, "2nd Mapped address is not hugepage");
+ goto windup;
+ }
+ memset(p, 0, hpage_size);
+ memset(p + hpage_size, 0, hpage_size);
+ tst_res(TPASS, "Mapping without MAP_FIXED at %lx... completed", straddle_addr);
+ } else {
+ tst_res(TINFO, "Got %p instead, never mind, let's move to mapping with MAP_FIXED", p);
+ SAFE_MUNMAP(p, 2*hpage_size);
+ }
+
+ tst_res(TINFO, "Mapping with MAP_FIXED at %lx...", straddle_addr);
+ p = mmap((void *)straddle_addr, 2*hpage_size, PROT_READ|PROT_WRITE,
+ MAP_SHARED|MAP_FIXED, fd, 0);
+
+ if (p == MAP_FAILED) {
+ /* this area crosses last low slice and first high slice */
+ unsigned long below_start = 4.0*TST_GB - 256L*1024*1024;
+ unsigned long above_end = 1024L*1024*1024*1024;
+
+ if (tst_mapping_in_range(below_start, above_end) == 1) {
+ tst_res(TFAIL | TERRNO, "region (4G-256M)-1T is not free");
+ goto windup;
+ } else {
+ tst_res(TFAIL, "mmap() with MAP_FIXED failed: %s", strerror(errno));
+ goto windup;
+ }
+ }
+
+ if (p != (void *)straddle_addr) {
+ tst_res(TINFO, "got %p instead", p);
+ tst_res(TFAIL, "Wrong address with MAP_FIXED");
+ goto windup;
+ }
+
+ if (test_addr_huge(p) != 1) {
+ tst_res(TFAIL, "1st Mapped address is not hugepage");
+ goto windup;
+ }
+
+ if (test_addr_huge(p + hpage_size) != 1) {
+ tst_res(TFAIL, "2nd Mapped address is not hugepage");
+ goto windup;
+ }
+
+ memset(p, 0, hpage_size);
+ memset(p + hpage_size, 0, hpage_size);
+ tst_res(TPASS, "Mapping with MAP_FIXED at %lx... completed", straddle_addr);
+
+windup:
+ SAFE_MUNMAP(p, 2*hpage_size);
+}
+
+static void setup(void)
+{
+ hpage_size = tst_get_hugepage_size();
+
+ if (hpage_size < 0) {
+ if (errno == ENOSYS)
+ tst_res(TINFO, "No hugepage kernel support");
+ else if (errno == EOVERFLOW)
+ tst_res(TINFO, "Hugepage size too large");
+ else
+ tst_res(TINFO, "Hugepage size (%s)", strerror(errno));
+ }
+
+ straddle_addr = 4.0*TST_GB - hpage_size;
+ fd = tst_creat_unlinked(MNTPOINT, 0, 0600);
+ if (hpage_size > 4.0*TST_GB)
+ tst_brk(TCONF, "Huge page size is too large!");
+}
+
+static void cleanup(void)
+{
+ if (fd >= 0)
+ SAFE_CLOSE(fd);
+}
+
+static struct tst_test test = {
+ .needs_root = 1,
+ .mntpoint = MNTPOINT,
+ .needs_hugetlbfs = 1,
+ .hugepages = {2, TST_NEEDS},
+ .setup = setup,
+ .cleanup = cleanup,
+ .test_all = run_test,
+};
--
2.43.5
More information about the ltp
mailing list