[LTP] [PATCH 1/1] prepare_lvm.sh: Use $TMPDIR instead of custom $LVM_DIR
Petr Vorel
pvorel@suse.cz
Thu Oct 16 10:35:34 CEST 2025
Allow users to reuse TMPDIR environment variable instead of forcing them
to export LVM_DIR, which would behave the same as TMPDIR.
LVM_DIR is undocumented users expect TMPDIR.
Fixes: 0838220f25 ("prepare_lvm.sh: Allow to define tmp directory")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi,
it was me who introduced LVM_DIR, but thinking about it twice it was not
a good idea.
Kind regards,
Petr
testcases/misc/lvm/cleanup_lvm.sh | 8 ++++----
testcases/misc/lvm/generate_lvm_runfile.sh | 4 ++--
testcases/misc/lvm/prepare_lvm.sh | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/testcases/misc/lvm/cleanup_lvm.sh b/testcases/misc/lvm/cleanup_lvm.sh
index f05289f008..b098359e1a 100755
--- a/testcases/misc/lvm/cleanup_lvm.sh
+++ b/testcases/misc/lvm/cleanup_lvm.sh
@@ -8,9 +8,9 @@ TST_TESTFUNC=cleanup_lvm
TST_NEEDS_ROOT=1
TST_NEEDS_CMDS="losetup umount vgremove"
-LVM_DIR="${LVM_DIR:-/tmp}"
-LVM_TMPDIR="$LVM_DIR/ltp/growfiles"
-LVM_IMGDIR="$LVM_DIR/ltp/imgfiles"
+TMPDIR="${TMPDIR:-/tmp}"
+LVM_TMPDIR="$TMPDIR/ltp/growfiles"
+LVM_IMGDIR="$TMPDIR/ltp/imgfiles"
cleanup_lvm()
{
@@ -27,7 +27,7 @@ cleanup_lvm()
ROD tst_device release $devname
done
- rm -rf $LVM_DIR/ltp
+ rm -rf $TMPDIR/ltp
tst_res TPASS "LVM configuration for LTP removed successfully."
}
diff --git a/testcases/misc/lvm/generate_lvm_runfile.sh b/testcases/misc/lvm/generate_lvm_runfile.sh
index 7f7e149d94..c95c4b880e 100755
--- a/testcases/misc/lvm/generate_lvm_runfile.sh
+++ b/testcases/misc/lvm/generate_lvm_runfile.sh
@@ -9,8 +9,8 @@ TST_TESTFUNC=generate_runfile
TST_NEEDS_ROOT=1
TST_NEEDS_CMDS="sed"
-LVM_DIR="${LVM_DIR:-/tmp}"
-LVM_TMPDIR="$LVM_DIR/ltp/growfiles"
+TMPDIR="${TMPDIR:-/tmp}"
+LVM_TMPDIR="$TMPDIR/ltp/growfiles"
generate_runfile()
{
diff --git a/testcases/misc/lvm/prepare_lvm.sh b/testcases/misc/lvm/prepare_lvm.sh
index 29f386df83..2ac844b0db 100755
--- a/testcases/misc/lvm/prepare_lvm.sh
+++ b/testcases/misc/lvm/prepare_lvm.sh
@@ -8,9 +8,9 @@ TST_TESTFUNC=prepare_lvm
TST_NEEDS_ROOT=1
TST_NEEDS_CMDS="mount pvcreate vgcreate lvcreate"
-LVM_DIR="${LVM_DIR:-/tmp}"
-LVM_TMPDIR="$LVM_DIR/ltp/growfiles"
-LVM_IMGDIR="$LVM_DIR/ltp/imgfiles"
+TMPDIR="${TMPDIR:-/tmp}"
+LVM_TMPDIR="$TMPDIR/ltp/growfiles"
+LVM_IMGDIR="$TMPDIR/ltp/imgfiles"
error_check()
{
--
2.51.0
More information about the ltp
mailing list