[LTP] [PATCH] fanotify24: Verify expected count/offset info in pre content events

[Jan Kara]

On Mon 20-10-25 22:22:31, Petr Vorel wrote:
> Hi Amir, all,
> 
> > To test fix commit 28bba2c2935e2 ("fsnotify: Pass correct offset to
> > fsnotify_mmap_perm()"), diversify the offsets and count used for mmap()
> > write() and read() and verify that the FAN_PRE_ACCESS events report the
> > expected count/offset.
> 
> > For the FAN_PRE_ACCESS events generated by execve(), we cannot
> > anticipate the exact ranges, so we set 0 count to skip this verification.
> 
> > Also add prints of path of the fd passed with the event (not verified
> > against expected path).
> 
> > Make sure that we take the expected error value for an operation
> > (e.g. read) from a matching event type (e.g. FAN_PRE_ACCESS).
> 
> Thanks for the update.  LGTM, but it'd be great if some of kernel developers
> also had look into it. Few minor notes below.
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>

The changes look good to me as well (modulo some of of the style issues
you've pointed out) so feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR