[LTP] kirk cannot handle env variable correctly

[Li Wang]

After looking at the ltp.py, it overrides the user-set LTP_TIMEOUT_MUL env
variable.
So maybe we need to enable that to config by --env, what do you think?

--- a/libkirk/ltp.py
+++ b/libkirk/ltp.py
@@ -64,7 +64,8 @@ class LTPFramework(Framework):
             self._env.update(env)

         timeout = libkirk.types.dict_item(kwargs, "test_timeout", float)
-        if timeout:
+        user_timeout_mul = os.environ.get("LTP_TIMEOUT_MUL")
+        if timeout and not user_timeout_mul:
             self._env["LTP_TIMEOUT_MUL"] = str((timeout * 0.9) / 300.0)


On Tue, Sep 16, 2025 at 12:23 PM Li Wang <liwang@redhat.com> wrote:

> Hi Andrea, All,
>
> We discovered that the LTP tests in the CI job all had a fixed timeout
> value set,
> regardless of LTP_TIMEOUT_MUL or LTP_RUNTIME_MUL . This only seemed
> to happen when running Kirk, so to demonstrate the issue I manually ran the
> following test:
>
> =================
> # ./kirk --framework ltp:root=/mnt/testarea/ltp --run-command mmap22 --env
> LTP_TIMEOUT_MUL=1
> Host information
>
> System: Linux
> Node: hp-dl380g10-01-vm-02.rhts.eng.pek2.redhat.com
> Kernel Release: 6.12.0-124.el10.x86_64+rt
> Kernel Version: #1 SMP PREEMPT_RT Fri Aug 22 11:49:27 EDT 2025
> Machine Architecture: x86_64
> Processor:
>
> Temporary directory: /tmp/kirk.root/tmptyhqv079
>
> Connecting to SUT: host
> mmap22
> tst_tmpdir.c:316: TINFO: Using /tmp/LTP_mmafXwQ0v as tmpdir (xfs
> filesystem)
> tst_test.c:1953: TINFO: LTP version: 20250530
> tst_test.c:1956: TINFO: Tested kernel: 6.12.0-124.el10.x86_64+rt #1 SMP
> PREEMPT_RT Fri Aug 22 11:49:27 EDT 2025 x86_64
> tst_kconfig.c:88: TINFO: Parsing kernel config
> '/lib/modules/6.12.0-124.el10.x86_64+rt/config'
> tst_test.c:1774: TINFO: Overall timeout per run is 0h 05m 54s
> mmap22.c:63: TPASS: MAP_DROPPABLE test pass.
>
> Summary:
> passed   1
> failed   0
> broken   0
> skipped  0
> warnings 0
>
> Exit code: 0
>
>
> Disconnecting from SUT: host
> Session stopped
>
>
> ==================
> # export LTP_TIMEOUT_MUL=1
> # ./kirk --framework ltp:root=/mnt/testarea/ltp --run-command mmap22
> Host information
>
> System: Linux
> Node: hp-dl380g10-01-vm-02.rhts.eng.pek2.redhat.com
> Kernel Release: 6.12.0-124.el10.x86_64+rt
> Kernel Version: #1 SMP PREEMPT_RT Fri Aug 22 11:49:27 EDT 2025
> Machine Architecture: x86_64
> Processor:
>
> Temporary directory: /tmp/kirk.root/tmpw5dssvts
>
> Connecting to SUT: host
> mmap22
> tst_tmpdir.c:316: TINFO: Using /tmp/LTP_mmafWMgDV as tmpdir (xfs
> filesystem)
> tst_test.c:1953: TINFO: LTP version: 20250530
> tst_test.c:1956: TINFO: Tested kernel: 6.12.0-124.el10.x86_64+rt #1 SMP
> PREEMPT_RT Fri Aug 22 11:49:27 EDT 2025 x86_64
> tst_kconfig.c:88: TINFO: Parsing kernel config
> '/lib/modules/6.12.0-124.el10.x86_64+rt/config'
> tst_test.c:1774: TINFO: Overall timeout per run is 0h 05m 54s
> mmap22.c:63: TPASS: MAP_DROPPABLE test pass.
>
> Summary:
> passed   1
> failed   0
> broken   0
> skipped  0
> warnings 0
>
> Exit code: 0
>
>
> Disconnecting from SUT: host
> Session stopped
>
> ================
> # LTP_TIMEOUT_MUL=1 ./mmap22
> tst_tmpdir.c:316: TINFO: Using /tmp/LTP_mmaGHM6fT as tmpdir (xfs
> filesystem)
> tst_test.c:1953: TINFO: LTP version: 20250530
> tst_test.c:1956: TINFO: Tested kernel: 6.12.0-124.el10.x86_64+rt #1 SMP
> PREEMPT_RT Fri Aug 22 11:49:27 EDT 2025 x86_64
> tst_kconfig.c:88: TINFO: Parsing kernel config
> '/lib/modules/6.12.0-124.el10.x86_64+rt/config'
> tst_test.c:1774: TINFO: Overall timeout per run is 0h 01m 00s
> mmap22.c:63: TPASS: MAP_DROPPABLE test pass.
>
> Summary:
> passed   1
> failed   0
> broken   0
> skipped  0
> warnings 0
>
>
>
> --
> Regards,
> Li Wang
>


-- 
Regards,
Li Wang