[LTP] [PATCH v6 5/7] Add file_attr02 test

[Martin Doucha]

Hi,
I've done pre-release testing and found two issues in this test.

On 8/7/25 09:01, Andrea Cervesato wrote:
> From: Andrea Cervesato <andrea.cervesato@suse.com>
> 
> Verify that `file_getattr` is correctly reading filesystems additional
> attributes. We are running test on XFS only, since it's the only filesystem
> currently implementing the features we need.
> 
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ---
>   runtest/syscalls                                  |  1 +
>   testcases/kernel/syscalls/file_attr/.gitignore    |  1 +
>   testcases/kernel/syscalls/file_attr/file_attr02.c | 92 +++++++++++++++++++++++
>   3 files changed, 94 insertions(+)
> 
> diff --git a/runtest/syscalls b/runtest/syscalls
> index fed17a38baf0586ec886876b58c04158fa11e8e0..b69e474a6a596359bb1ace30312b55d6bf2b65cc 100644
> --- a/runtest/syscalls
> +++ b/runtest/syscalls
> @@ -247,6 +247,7 @@ fsetxattr01 fsetxattr01
>   fsetxattr02 fsetxattr02
>   
>   file_attr01 file_attr01
> +file_attr02 file_attr02
>   
>   #posix_fadvise test cases
>   posix_fadvise01                      posix_fadvise01
> diff --git a/testcases/kernel/syscalls/file_attr/.gitignore b/testcases/kernel/syscalls/file_attr/.gitignore
> index de06f204d34be482a6401f2a5e7931caa5e3ab12..afe9c2fc9a4218dc032f044c1d317355a784a525 100644
> --- a/testcases/kernel/syscalls/file_attr/.gitignore
> +++ b/testcases/kernel/syscalls/file_attr/.gitignore
> @@ -1 +1,2 @@
>   file_attr01
> +file_attr02
> diff --git a/testcases/kernel/syscalls/file_attr/file_attr02.c b/testcases/kernel/syscalls/file_attr/file_attr02.c
> new file mode 100644
> index 0000000000000000000000000000000000000000..4e0d87f0f3edc946bf9cd14e76cce9518bf928d0
> --- /dev/null
> +++ b/testcases/kernel/syscalls/file_attr/file_attr02.c
> @@ -0,0 +1,92 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (C) 2025 SUSE LLC Andrea Cervesato <andrea.cervesato@suse.com>
> + */
> +
> +/*\
> + * Verify that `file_getattr` is correctly reading filesystems additional
> + * attributes. We are running test on XFS only, since it's the only filesystem
> + * currently implementing the features we need.
> + */
> +
> +#include "tst_test.h"
> +#include "lapi/fs.h"
> +
> +#define MNTPOINT "mntpoint"
> +#define FILENAME "ltp_file"
> +#define BLOCKS 1024
> +#define PROJID 16
> +
> +static int fd = -1;
> +static int dfd = -1;
> +static struct fsxattr xattr;
> +static struct file_attr *attr;
> +
> +static void run(void)
> +{
> +	memset(attr, 0, sizeof(*attr));
> +
> +	TST_EXP_PASS(file_getattr(
> +		dfd, FILENAME,
> +		attr, FILE_ATTR_SIZE_LATEST,
> +		0));
> +
> +	TST_EXP_EQ_LI(attr->fa_xflags, xattr.fsx_xflags);
> +	TST_EXP_EQ_LI(attr->fa_extsize, xattr.fsx_extsize);
> +	TST_EXP_EQ_LI(attr->fa_cowextsize, xattr.fsx_cowextsize);
> +	TST_EXP_EQ_LI(attr->fa_nextents, xattr.fsx_nextents);
> +	TST_EXP_EQ_LI(attr->fa_projid, PROJID);
> +	TST_EXP_EQ_LI(attr->fa_projid, xattr.fsx_projid);
> +}
> +
> +static void setup(void)
> +{
> +	int block_size;
> +
> +	block_size = tst_dev_block_size(MNTPOINT);

This is the wrong blocksize. You don't want the physical blocksize from 
the underlying block device. You want the filesystem blocksize reported 
by stat(MNTPOINT).

> +
> +	dfd = SAFE_OPEN(MNTPOINT, O_RDONLY);
> +	fd = SAFE_CREAT(MNTPOINT "/" FILENAME, 0777);
> +
> +	SAFE_IOCTL(fd, FS_IOC_FSGETXATTR, &xattr);
> +
> +	xattr.fsx_xflags |= FS_XFLAG_EXTSIZE;
> +	xattr.fsx_xflags |= FS_XFLAG_COWEXTSIZE;
> +	xattr.fsx_extsize = BLOCKS * block_size;
> +	xattr.fsx_cowextsize = BLOCKS * block_size;
> +	xattr.fsx_projid = PROJID;
> +
> +	SAFE_IOCTL(fd, FS_IOC_FSSETXATTR, &xattr);
> +
> +	/* this will force at least one extent to be allocated */
> +	SAFE_WRITE(SAFE_WRITE_ALL, fd, "a", 1);
> +
> +	SAFE_IOCTL(fd, FS_IOC_FSGETXATTR, &xattr);
> +	SAFE_CLOSE(fd);
> +}
> +
> +static void cleanup(void)
> +{
> +	if (fd != -1)
> +		SAFE_CLOSE(fd);
> +
> +	if (dfd != -1)
> +		SAFE_CLOSE(dfd);
> +}
> +
> +static struct tst_test test = {
> +	.test_all = run,
> +	.setup = setup,
> +	.cleanup = cleanup,
> +	.mntpoint = MNTPOINT,
> +	.needs_root = 1,
> +	.mount_device = 1,
> +	.filesystems = (struct tst_fs []) {
> +		{.type = "xfs"},
> +		{}
> +	},
> +	.bufs = (struct tst_buffers []) {
> +		{&attr, .size = sizeof(struct file_attr)},

You also need to enable reflink support with -m reflink=1 mkfs option, 
otherwise setting fsx_cowextsize in setup() will fail on older systems.

> +		{}
> +	}
> +};
> 


-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic