[LTP] [PATCH v4] Introduce ioctl_pidfd_get_info_supported() function

[Li Wang]

On Thu, Sep 25, 2025 at 4:29 AM Avinesh Kumar <akumar@suse.de> wrote:

> Check if ioctl(PIDFD_GET_INFO) is implemented or not
> before proceeding in ioctl_pidfd05 test
>
> Suggested-by: Cyril Hrubis <chrubis@suse.cz>
> Suggested-by: Petr Vorel <pvorel@suse.cz>
> Signed-off-by: Avinesh Kumar <akumar@suse.de>
>

This version looks much more elegant.

Reviewed-by: Li Wang <liwang@redhat.com>

---
>  testcases/kernel/syscalls/ioctl/ioctl_pidfd.h | 28 +++++++++++++++++++
>  .../kernel/syscalls/ioctl/ioctl_pidfd05.c     |  9 +++++-
>  2 files changed, 36 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/ioctl/ioctl_pidfd.h
> b/testcases/kernel/syscalls/ioctl/ioctl_pidfd.h
> index 811f969cd..b785d8043 100644
> --- a/testcases/kernel/syscalls/ioctl/ioctl_pidfd.h
> +++ b/testcases/kernel/syscalls/ioctl/ioctl_pidfd.h
> @@ -9,6 +9,34 @@
>  #include "tst_test.h"
>  #include "lapi/pidfd.h"
>
> +static inline bool ioctl_pidfd_get_info_supported(void)
> +{
> +       pid_t pid;
> +       int pidfd, ret;
> +       int supported = 0;
> +       struct pidfd_info info;
> +
> +       if (tst_kvercmp(6, 13, 0) >= 0)
> +               return 1;
> +
> +       memset(&info, 0, sizeof(struct pidfd_info));
> +
> +       pid = SAFE_FORK();
> +       if (!pid)
> +               exit(100);
> +
> +       pidfd = SAFE_PIDFD_OPEN(pid, 0);
> +
> +       ret = ioctl(pidfd, PIDFD_GET_INFO, &info);
> +       SAFE_WAITPID(pid, NULL, 0);
> +
> +       if (ret != -1)
> +               supported = 1;
> +
> +       SAFE_CLOSE(pidfd);
> +       return supported;
> +}
> +
>  static inline int ioctl_pidfd_info_exit_supported(void)
>  {
>         int ret;
> diff --git a/testcases/kernel/syscalls/ioctl/ioctl_pidfd05.c
> b/testcases/kernel/syscalls/ioctl/ioctl_pidfd05.c
> index c379717b3..d20c6f074 100644
> --- a/testcases/kernel/syscalls/ioctl/ioctl_pidfd05.c
> +++ b/testcases/kernel/syscalls/ioctl/ioctl_pidfd05.c
> @@ -14,7 +14,7 @@
>  #include "tst_test.h"
>  #include "lapi/pidfd.h"
>  #include "lapi/sched.h"
> -#include "lapi/ioctl.h"
> +#include "ioctl_pidfd.h"
>
>  struct pidfd_info_invalid {
>         uint32_t dummy;
> @@ -48,8 +48,15 @@ static void run(void)
>         SAFE_CLOSE(pidfd);
>  }
>
> +static void setup(void)
> +{
> +       if (!ioctl_pidfd_get_info_supported())
> +               tst_brk(TCONF, "ioctl(PIDFD_GET_INFO) is not implemented");
> +}
> +
>  static struct tst_test test = {
>         .test_all = run,
> +       .setup = setup,
>         .forks_child = 1,
>         .bufs = (struct tst_buffers []) {
>                 {&args, .size = sizeof(*args)},
> --
> 2.51.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
>

-- 
Regards,
Li Wang