[LTP] [PATCH] include/lapi: add leaf Makefile

[Li Wang]

Petr Vorel <pvorel@suse.cz> wrote:

> > > +INSTALL_DIR            := $(includedir)/lapi
>
> > I'm doubting should we install the include/lapi/ local header files to
> > the /opt/ltp/include?
>
> Do you question *whether* install lapi/*.h or *where* to install them?
> We install include/*.h files. What is a difference with include/lapi/?

The former, I guess we don't need to install any.

> I'd say either install both or none. I would prefer to not install any,
> LTP library is not separated anyway (there is an old Andrea's effort, but that
> uses meson anyway). Installation was added in 2008 and I doubt anybody is using
> it.

Yes, that was exactly my point, we'd better remove the INSTALL_* part
from the Makefile you posted.

-INSTALL_DIR            := $(includedir)/lapi
-
-INSTALL_MODE           := 00644
-
-INSTALL_TARGETS                := *.h

> > > --- include/lapi/syscalls/Makefile
> > > +++ /dev/null
>
> > Does the `make check` still work (inside include/lapi/syscalls/)
> > without this Makefile?
>
> Sure not. Do we really want to check generate_arch.sh and generate_syscalls.sh
> in arch? If yes, sure it needs to be added, but that was not my intention when
> creating #1262. I really wanted to check C (and shell) library and tests code.

I'm ok with both, so without that Makefile we could do `make check` in
/include/lapi/.


-- 
Regards,
Li Wang