[LTP] [PATCH v7] fstat: add test for multiple file types using fstat

Jinseok Kim always.starving0@gmail.com
Tue Apr 21 17:24:33 CEST 2026


Hi,

Thanks for the review.

S_IFLNK is not suitable here since this test is based on fstat(), which
follows symlinks. It is already covered by lstat tests (e.g. lstat01).
This was also discussed here:
https://lore.kernel.org/ltp/69b42eee.050a0220.281abf.2706@mx.google.com

S_IFSOCK is also excluded since filesystem sockets cannot be opened,
so they cannot be verified via fstat().

I think both cases are better covered by lstat/stat based tests.

Thanks,
Jinseok


More information about the ltp mailing list