[LTP] [PATCH v2] cfs-scheduler: Fixed "make check" errors and warnings.
Samir M
samir@linux.ibm.com
Tue Apr 28 13:13:57 CEST 2026
On 12/04/26 5:58 pm, Samir wrote:
> Fixed all make check errors and warnings in cfs_bandwidth01.c and
> hackbench.c to comply with LTP coding style.
>
> cfs_bandwidth01.c:
> - Remove initialization of static variable to 0
>
> Patch v1: https://lore.kernel.org/ltp/20260407062336.127454-1-samir@linux.ibm.com/
>
> Addressed review comments from patch v1 -> patch v2
> hackbench.c:
> - Drop SPDX-License-Identifier header addition.
> - Remove obsolete header metadata.
> - Keep short description and add trailing period.
> - Remove initialization of static variables to 0.
> - Convert zero-length array to C99 flexible array.
> - Drop variadic barf() change.
> - Drop __func__-based error messages.
> - Separate assignments from if conditions.
> - Fix pointer declaration spacing.
> - Add blank line after declarations.
> - Fix spacing in macro and struct initialization.
> - Remove unnecessary braces for single statement.
> - Use Authors block for contributor attribution.
>
> Signed-off-by: Samir <samir@linux.ibm.com>
> ---
> .../sched/cfs-scheduler/cfs_bandwidth01.c | 2 +-
> .../kernel/sched/cfs-scheduler/hackbench.c | 71 ++++++-------------
> 2 files changed, 24 insertions(+), 49 deletions(-)
>
> diff --git a/testcases/kernel/sched/cfs-scheduler/cfs_bandwidth01.c b/testcases/kernel/sched/cfs-scheduler/cfs_bandwidth01.c
> index e52858f8e..8c511f060 100644
> --- a/testcases/kernel/sched/cfs-scheduler/cfs_bandwidth01.c
> +++ b/testcases/kernel/sched/cfs-scheduler/cfs_bandwidth01.c
> @@ -35,7 +35,7 @@
>
> static struct tst_cg_group *cg_level2, *cg_level3a, *cg_level3b;
> static struct tst_cg_group *cg_workers[3];
> -static int may_have_waiters = 0;
> +static int may_have_waiters;
>
> static void set_cpu_quota(const struct tst_cg_group *const cg,
> const float quota_percent)
> diff --git a/testcases/kernel/sched/cfs-scheduler/hackbench.c b/testcases/kernel/sched/cfs-scheduler/hackbench.c
> index 6f37060aa..846985e3b 100644
> --- a/testcases/kernel/sched/cfs-scheduler/hackbench.c
> +++ b/testcases/kernel/sched/cfs-scheduler/hackbench.c
> @@ -1,49 +1,20 @@
> /******************************************************************************/
> -/* Copyright Rusty Russell, */
> -/* Copyright Pierre Peiffer */
> -/* Copyright Zhang, Yanmin, */
> -/* Copyright Ingo Molnar, */
> -/* Copyright Arjan van de Ven, */
> /* Copyright (c) International Business Machines Corp., 2008 */
> /* */
> -/* This program is free software; you can redistribute it and/or modify */
> -/* it under the terms of the GNU General Public License as published by */
> -/* the Free Software Foundation; either version 2 of the License, or */
> -/* (at your option) any later version. */
> -/* */
> -/* This program is distributed in the hope that it will be useful, */
> -/* but WITHOUT ANY WARRANTY; without even the implied warranty of */
> -/* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See */
> -/* the GNU General Public License for more details. */
> -/* */
> -/* You should have received a copy of the GNU General Public License */
> -/* along with this program; if not, write to the Free Software */
> -/* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */
> +/* Authors: Rusty Russell <rusty@rustcorp.com.au> */
> +/* Pierre Peiffer <pierre.peiffer@bull.net> */
> +/* Ingo Molnar <mingo@elte.hu> */
> +/* Arjan van de Ven <arjan@infradead.org> */
> +/* "Zhang, Yanmin" <yanmin_zhang@linux.intel.com> */
> +/* Nathan Lynch <ntl@pobox.com> */
> +/* Subrata Modak <subrata@linux.vnet.ibm.com> */
> /* */
> /******************************************************************************/
>
> /******************************************************************************/
> /* */
> -/* File: hackbench.c */
> -/* */
> /* Description: hackbench tests the Linux scheduler. Test groups of 20 */
> -/* processes spraying to 20 receivers */
> -/* */
> -/* Total Tests: 1 */
> -/* */
> -/* Test Name: hackbench01 and hackbench02 */
> -/* */
> -/* Test Assertion: */
> -/* */
> -/* Author(s): Rusty Russell <rusty@rustcorp.com.au>, */
> -/* Pierre Peiffer <pierre.peiffer@bull.net>, */
> -/* Ingo Molnar <mingo@elte.hu>, */
> -/* Arjan van de Ven <arjan@infradead.org>, */
> -/* "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>, */
> -/* Nathan Lynch <ntl@pobox.com> */
> -/* */
> -/* History: Included into LTP */
> -/* - June 26 2008 - Subrata Modak<subrata@linux.vnet.ibm.com>*/
> +/* processes spraying to 20 receivers. */
> /* */
> /******************************************************************************/
> #include <pthread.h>
> @@ -59,24 +30,24 @@
> #include <sys/poll.h>
> #include <limits.h>
>
> -#define SAFE_FREE(p) { if (p) { free(p); (p)=NULL; } }
> +#define SAFE_FREE(p) { if (p) { free(p); (p) = NULL; } }
> #define DATASIZE 100
> static struct sender_context **snd_ctx_tab; /*Table for sender context pointers. */
> static struct receiver_context **rev_ctx_tab; /*Table for receiver context pointers. */
> -static int gr_num = 0; /*For group calculation */
> +static int gr_num; /*For group calculation */
> static unsigned int loops = 100;
> /*
> * 0 means thread mode and others mean process (default)
> */
> static unsigned int process_mode = 1;
>
> -static int use_pipes = 0;
> +static int use_pipes;
>
> struct sender_context {
> unsigned int num_fds;
> int ready_out;
> int wakefd;
> - int out_fds[0];
> + int out_fds[];
> };
>
> struct receiver_context {
> @@ -115,7 +86,7 @@ static void fdpair(int fds[2])
> static void ready(int ready_out, int wakefd)
> {
> char dummy;
> - struct pollfd pollfd = {.fd = wakefd,.events = POLLIN };
> + struct pollfd pollfd = {.fd = wakefd, .events = POLLIN };
>
> /* Tell them we're ready. */
> if (write(ready_out, &dummy, 1) != 1)
> @@ -210,7 +181,8 @@ pthread_t create_worker(void *ctx, void *(*func) (void *))
> barf("pthread_attr_setstacksize");
> #endif
>
> - if ((err = pthread_create(&childid, &attr, func, ctx)) != 0) {
> + err = pthread_create(&childid, &attr, func, ctx);
> + if (err != 0) {
> fprintf(stderr, "pthread_create failed: %s (%d)\n",
> strerror(err), err);
> exit(-1);
> @@ -235,11 +207,12 @@ void reap_worker(pthread_t id)
> }
>
> /* One group of senders and receivers */
> -static unsigned int group(pthread_t * pth,
> +static unsigned int group(pthread_t *pth,
> unsigned int num_fds, int ready_out, int wakefd)
> {
> unsigned int i;
> struct sender_context *snd_ctx = malloc(sizeof(struct sender_context) + num_fds * sizeof(int));
> +
> if (!snd_ctx)
> barf("malloc()");
> else
> @@ -305,8 +278,11 @@ int main(int argc, char *argv[])
> argv++;
> }
>
> - if (argc >= 2 && (num_groups = atoi(argv[1])) == 0)
> - print_usage_exit();
> + if (argc >= 2) {
> + num_groups = atoi(argv[1]);
> + if (num_groups == 0)
> + print_usage_exit();
> + }
>
> printf("Running with %d*40 (== %d) tasks.\n",
> num_groups, num_groups * 40);
> @@ -363,9 +339,8 @@ int main(int argc, char *argv[])
>
> /* free the memory */
> for (i = 0; i < num_groups; i++) {
> - for (j = 0; j < num_fds; j++) {
> + for (j = 0; j < num_fds; j++)
> SAFE_FREE(rev_ctx_tab[i * num_fds + j])
> - }
> SAFE_FREE(snd_ctx_tab[i]);
> }
> SAFE_FREE(pth_tab);
Hi,
I wanted to gently follow up on this patch submission. If you have any
feedback or concerns, I'm happy to address them and submit a revised
version.
Thank you for your time and consideration.
Best regards,
Samir (samir@linux.ibm.com)
More information about the ltp
mailing list