[LTP] ima_violations.sh: Wait for ima_mmap to exit

linuxtestproject.agent@gmail.com linuxtestproject.agent@gmail.com
Tue Apr 28 18:59:51 CEST 2026


Hi Petr,

On Tue, Apr 28, 2026 at 18:10:33 +0200, Petr Vorel wrote:
> ima_violations.sh: Wait for ima_mmap to exit
> ima_violations.sh: ima_mmap.c: Replace sleep with checkpoints

Both patches look good.

Reviewed-by: LTP AI Reviewer <ltp-ai@noreply.github.com>

Pre-existing issues noticed in the surrounding code (not introduced
by this patch):

- ima_mmap.c:2-8 — no doc comment describing the test; only a copyright block present
- ima_violations.sh — missing # --- doc and # --- env blocks
- ima_mmap.c:18-25 — cleanup() does not set file = NULL after SAFE_MUNMAP

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/25066130804

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer


More information about the ltp mailing list