[LTP] thermal: add new test group

[Kubaj, Piotr]

2026-04-30 (木) の 09:18 +0000 に linuxtestproject.agent@gmail.com
さんは書きました:
> Hi Piotr,
> 
> On Thu, 30 Apr 2026 10:42:40 +0200, Piotr Kubaj wrote:
> > [PATCH] thermal: add new test group
> 
> > +# Copyright (c) 2025, Intel Corporation. All rights reserved.
> 
> Wrong year in the new Makefile -- should be 2026.
> 
> > +	while (sleep_time > 0) {
> > +		[...]
> > +		tst_reap_children();
> > +		[...]
> > +		sleep(sleep_time--);
> 
> sleep() must not be used for synchronization (G2). The children are
> already reaped with tst_reap_children(); this sleep is waiting for a
> hardware thermal state change. Use a polling loop with
> tst_timer_start()/tst_timer_expired_ms() instead, which you already
> use in cpu_workload().
This sleep is not used for synchronization, but to wait until the CPU
cools down. There are some preproduction CPU's that have non-
functioning thermal sensors and may be damaged if this sleep is
omitted.

While I could use tst_timer_start()/tst_timer_expired_ms() instead, I
find it quite pointless. cpu_workload() uses it, because there I want
the whole loop to take no more than run_time. Here, I just want to wait
sleep_time.

> 
> ---
> Note:
> 
> Our agent completed the review of the patch.
> 
> The agent can sometimes produce false positives although often its
> findings are genuine. If you find issues with the review, please
> comment this email or ignore the suggestions.
> 
> Regards,
> LTP AI Reviewer
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.