[LTP] mem/hugetlb: use SAFE_SHMGET() and fix checkpatch warnings in hugeshmget
linuxtestproject.agent@gmail.com
linuxtestproject.agent@gmail.com
Tue Aug 18 21:29:56 CEST 2026
Hi Samir,
On Tue, Aug 18, 2026, Samir Mulani wrote:
> mem/hugetlb: use SAFE_SHMGET() and fix checkpatch warnings in hugeshmget
> + shm_id_1 = SAFE_SHMGET(shmkey, shm_size,
> + SHM_HUGETLB | IPC_CREAT | IPC_EXCL | SHM_RW);
> - tst_res(TFAIL | TTERRNO, "shmget failed unexpectedly "
> - "- expect errno=ENOSPC, got");
> + tst_res(TFAIL | TTERRNO,
> + "shmget failed unexpectedly - expect errno=ENOSPC, got");
Severity: medium
Could the checkpatch-only changes be moved to a separate patch? The
SAFE_SHMGET() conversion is a behavioral API cleanup, while hugeshmget03
contains only independent message-formatting changes. LTP requires each
patch to contain one logical change.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
More information about the ltp
mailing list