[LTP] [PATCH STAGING v2 06/16] fchroot03: test fchroot() permission checks

[Cyril Hrubis]

Hi!
> > > Verify that with a regular directory fd the kernel first checks the
> > > execute permission on the directory and then CAP_SYS_CHROOT: an
> > > unprivileged process with an accessible directory fails with EPERM and
> > > a process without execute permission fails with EACCES.
> > 
> > Here as well, the order of the checks is subject to change.
> 
> sorry I don't get the review, can you please explain where is the
> issue? it's a description problem only?
> 
> same for the other reviews

The problem here is that the order in which kernel checks for
CAP_SYS_ROOT or invalid fchroot() flags is not defined. It checks for
CAP_SYS_ROOT last now, but that is not something we can take for
granted.

-- 
Cyril Hrubis
chrubis@suse.cz