[LTP] [PATCH v6] thermal: add new test group
Kubaj, Piotr
piotr.kubaj@intel.com
Wed Feb 18 12:37:51 CET 2026
Reply inline, I'll send updated version later.
2026-02-17 (火) の 11:49 +0100 に Andrea Cervesato さんは書きました:
> Hi!
>
> On Fri Feb 13, 2026 at 2:13 PM CET, Piotr Kubaj wrote:
> > This is a new test for checking thermal interrupt events.
> > I added some fixes suggested by Petr Vorel. Since no one else
> > reviewed this code and two weeks have passed, I'm sending the
> > corrected version.
> >
> > Signed-off-by: Piotr Kubaj <piotr.kubaj@intel.com>
> > ---
> > runtest/thermal | 3 +
> > scenario_groups/default | 1 +
> > testcases/kernel/Makefile | 1 +
> > testcases/kernel/thermal/Makefile | 9 +
> > .../kernel/thermal/thermal_interrupt_events.c | 209
> > ++++++++++++++++++
> > 5 files changed, 223 insertions(+)
> > create mode 100644 runtest/thermal
> > create mode 100644 testcases/kernel/thermal/Makefile
> > create mode 100644
> > testcases/kernel/thermal/thermal_interrupt_events.c
> >
> > diff --git a/runtest/thermal b/runtest/thermal
> > new file mode 100644
> > index 000000000..57e3d29f8
> > --- /dev/null
> > +++ b/runtest/thermal
> > @@ -0,0 +1,3 @@
> > +# Thermal driver API
> > +# https://docs.kernel.org/driver-api/thermal/
> > +thermal_interrupt_events thermal_interrupt_events
> > diff --git a/scenario_groups/default b/scenario_groups/default
> > index 0e76b2bee..ffdd7ff25 100644
> > --- a/scenario_groups/default
> > +++ b/scenario_groups/default
> > @@ -26,3 +26,4 @@ crypto
> > kernel_misc
> > uevent
> > watchqueue
> > +thermal
> > diff --git a/testcases/kernel/Makefile b/testcases/kernel/Makefile
> > index 98fd45a9d..ac816e4e8 100644
> > --- a/testcases/kernel/Makefile
> > +++ b/testcases/kernel/Makefile
> > @@ -36,6 +36,7 @@ SUBDIRS += connectors \
> > sched \
> > security \
> > sound \
> > + thermal \
> > tracing \
> > uevents \
> > watchqueue \
> > diff --git a/testcases/kernel/thermal/Makefile
> > b/testcases/kernel/thermal/Makefile
> > new file mode 100644
> > index 000000000..4657c3fb3
> > --- /dev/null
> > +++ b/testcases/kernel/thermal/Makefile
> > @@ -0,0 +1,9 @@
> > +# SPDX-License-Identifier: GPL-2.0-or-later
> > +# Copyright (c) 2025, Intel Corporation. All rights reserved.
> > +# Author:Piotr Kubaj <piotr.kubaj@intel.com>
> > +
> > +top_srcdir ?= ../../..
> > +
> > +include $(top_srcdir)/include/mk/testcases.mk
> > +
> > +include $(top_srcdir)/include/mk/generic_leaf_target.mk
> > diff --git a/testcases/kernel/thermal/thermal_interrupt_events.c
> > b/testcases/kernel/thermal/thermal_interrupt_events.c
> > new file mode 100644
> > index 000000000..d9105ff63
> > --- /dev/null
> > +++ b/testcases/kernel/thermal/thermal_interrupt_events.c
> > @@ -0,0 +1,209 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +
> > +/*
> > + * Copyright (C) 2025-2026 Intel - http://www.intel.com/
>
> Simply use 2026
Done.
>
> > + */
> > +
> > +/*\
> > + * Tests the CPU package thermal sensor interface for Intel
> > platforms.
> > +
> > + * Works by checking the initial count of thermal interrupts. Then
> > it
> > + * decreases the threshold for sending a thermal interrupt to just
> > above
> > + * the current temperature and runs a workload on the CPU.
> > Finally, it restores
> > + * the original thermal threshold and checks whether the number of
> > thermal
> > + * interrupts increased.
> > + */
> > +
> > +#include "tst_safe_stdio.h"
> > +#include "tst_test.h"
> > +
> > +#define RUNTIME 30
> > +#define SLEEP 10
> > +#define TEMP_INCREMENT 10
> > +
> > +static bool x86_pkg_temp_tz_found, *x86_pkg_temp_tz, status = 1;
> > +static char temp_path[NAME_MAX], trip_path[NAME_MAX];
> > +static int nproc, temp_high, temp, trip, tz_counter;
> > +static uint64_t *interrupt_init, *interrupt_later;
> > +
> > +static void read_interrupts(uint64_t *interrupts, const int nproc)
> > +{
> > + bool interrupts_found = false;
> > + char line[8192];
> > +
> > + memset(interrupts, 0, nproc * sizeof(*interrupts));
> > + FILE *fp = SAFE_FOPEN("/proc/interrupts", "r");
> > +
> > + while (fgets(line, sizeof(line), fp)) {
> > + if (strstr(line, "Thermal event interrupts")) {
> > + interrupts_found = true;
> > + char *token = strtok(line, " ");
> > +
> > + token = strtok(NULL, " ");
> > + int i = 0;
> > +
> > + while (!!strncmp(token, "Thermal", 7)) {
> > + interrupts[i++] = atoll(token);
> > + token = strtok(NULL, " ");
> > + tst_res(TDEBUG, "interrupts[%d]:
> > %ld", i - 1, interrupts[i - 1]);
> > + }
> > + break;
> > + }
> > + }
> > + SAFE_FCLOSE(fp);
> > + if (!interrupts_found)
> > + tst_brk(TCONF, "No Thermal event interrupts line
> > in /proc/interrupts");
> > +}
> > +
> > +static void setup(void)
> > +{
> > + char line[8192];
> > +
> > + nproc = tst_ncpus();
> > + tst_res(TDEBUG, "Number of logical cores: %d", nproc);
> > + interrupt_init = calloc(nproc, sizeof(uint64_t));
> > + interrupt_later = calloc(nproc, sizeof(uint64_t));
> > +
> > + DIR *dir = SAFE_OPENDIR("/sys/class/thermal/");
> > + struct dirent *entry;
> > +
> > + while ((entry = SAFE_READDIR(dir))) {
> > + if ((strncmp(entry->d_name, "thermal_zone",
> > sizeof("thermal_zone"))) > 0)
> > + tz_counter++;
> > + }
> > + SAFE_CLOSEDIR(dir);
> > + tst_res(TDEBUG, "Found %d thermal zone(s)", tz_counter);
> > +
> > + read_interrupts(interrupt_init, nproc);
> > +
> > + x86_pkg_temp_tz = calloc(tz_counter, sizeof(bool));
>
> This is never released.
Thanks, freed.
>
> > +
> > + for (int i = 0; i < tz_counter; i++) {
> > + char path[NAME_MAX];
> > +
> > + snprintf(path, NAME_MAX,
> > "/sys/class/thermal/thermal_zone%d/type", i);
> > + tst_res(TDEBUG, "Checking whether %s is
> > x86_pkg_temp", path);
> > +
> > + SAFE_FILE_SCANF(path, "%s", line);
> > + if (strstr(line, "x86_pkg_temp")) {
> > + tst_res(TDEBUG, "Thermal zone %d uses
> > x86_pkg_temp", i);
> > + x86_pkg_temp_tz[i] = 1;
> > + x86_pkg_temp_tz_found = 1;
> > + }
> > + }
> > +
> > + if (!x86_pkg_temp_tz_found)
> > + tst_brk(TCONF, "No thermal zone uses
> > x86_pkg_temp");
> > +}
> > +
> > +static void *cpu_workload(double run_time)
> > +{
> > + time_t start_time = time(NULL);
> > + int num = 2;
> > +
> > + while (difftime(time(NULL), start_time) < run_time) {
> > + for (int i = 2; i * i <= num; i++) {
> > + if (num % i == 0)
> > + break;
> > + }
> > + num++;
> > + SAFE_FILE_SCANF(temp_path, "%d", &temp);
> > +
> > + if (temp > temp_high)
> > + break;
> > + }
> > + return NULL;
> > +}
> > +
> > +static void test_zone(int i)
> > +{
> > + char path[NAME_MAX];
> > + int sleep_time = SLEEP;
> > + double run_time = RUNTIME;
>
> Here we should reset all variables which are used multiple times when
> -i
> parameter is used, otherwise we might have unexpected results between
> cycles.
I zero'd path at here in the newer version.
>
> > +
> > + snprintf(path, NAME_MAX,
> > "/sys/class/thermal/thermal_zone%d/", i);
> > + strncpy(temp_path, path, NAME_MAX);
> > + strncat(temp_path, "temp", 4);
>
> nit: why not just use (?):
Because path variable is used later to provide cleaner messages to the
user.
>
> snprintf(temp_path, NAME_MAX, "%stemp", path);
>
> > + tst_res(TINFO, "Testing %s", temp_path);
> > + SAFE_FILE_SCANF(temp_path, "%d", &temp);
> > + if (temp < 0) {
> > + tst_brk(TBROK, "Unexpected zone
> > temperature value %d", temp);
> > + status = 0;
>
> Anything after tst_brk() will be dead-code, so this status assignment
> is
> not needed.
Thanks, fixed.
>
> > + }
> > + tst_res(TDEBUG, "Current temperature for
> > %s: %d", path, temp);
> > +
> > + temp_high = temp + TEMP_INCREMENT;
> > +
> > + strncpy(trip_path, path, NAME_MAX);
> > + strncat(trip_path, "trip_point_1_temp",
> > 17);
> > +
> > + tst_res(TDEBUG, "Setting new
> > trip_point_1_temp value: %d", temp_high);
> > + SAFE_FILE_SCANF(trip_path, "%d", &trip);
> > + SAFE_FILE_PRINTF(trip_path, "%d",
> > temp_high);
> > +
> > + while (sleep_time > 0) {
> > + tst_res(TDEBUG, "Running for %f
> > seconds, then sleeping for %d seconds", run_time, sleep_time);
> > +
> > + for (int j = 0; j < nproc; j++) {
> > + if (!SAFE_FORK()) {
> > + cpu_workload(run_t
> > ime);
> > + exit(0);
> > + }
> > + }
> > +
> > + tst_reap_children();
> > +
> > + SAFE_FILE_SCANF(temp_path, "%d",
> > &temp);
> > + tst_res(TDEBUG, "Temperature for
> > %s after a test: %d", path, temp);
> > +
> > + if (temp > temp_high)
> > + break;
> > + sleep(sleep_time--);
> > + run_time -= 3;
> > + }
> > +
> > + if (temp <= temp_high) {
> > + tst_brk(TFAIL, "Zone temperature
> > is not rising as expected");
>
> tst_brk? If you want to raise a tst_brk() you should use TBROK.
> Otherwise, tst_res(TFAIL...).
Thanks, fixed.
>
> > + status = 0;
> > + }
> > +}
> > +
> > +static void cleanup(void)
> > +{
> > + if (x86_pkg_temp_tz_found)
> > + SAFE_FILE_PRINTF(trip_path, "%d", trip);
> > + free(interrupt_init);
> > + free(interrupt_later);
> > +}
> > +
> > +static void run(void)
> > +{
> > + for (int i = 0; i < tz_counter; i++) {
> > + if (x86_pkg_temp_tz[i])
> > + test_zone(i);
> > + }
> > + read_interrupts(interrupt_later, nproc);
> > +
> > + for (int i = 0; i < nproc; i++) {
> > + if (interrupt_later[i] < interrupt_init[i])
> > + tst_res(TFAIL, "CPU %d interrupt counter:
> > %ld (previous: %ld)",
> > + i, interrupt_later[i],
> > interrupt_init[i]);
>
> Here we are using the wrong printf() types format. Variables are
> defined
> as uint64_t* so "%llu" should be used.
That introduces a warning:
thermal_interrupt_events.c: In function ‘run’:
../../../include/tst_test.h:74:55: warning: format ‘%llu’ expects
argument of type ‘long long unsigned int’, but argument 6 has type
‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=]
74 | tst_res_(__FILE__, __LINE__, (ttype),
(arg_fmt), ##__VA_ARGS__);\
| ^~~~~~~~~
thermal_interrupt_events.c:186:25: note: in expansion of macro
‘tst_res’
186 | tst_res(TFAIL, "CPU %d interrupt
counter: %llu (previous: %llu)",
| ^~~~~~~
../../../include/tst_test.h:74:55: warning: format ‘%llu’ expects
argument of type ‘long long unsigned int’, but argument 7 has type
‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=]
74 | tst_res_(__FILE__, __LINE__, (ttype),
(arg_fmt), ##__VA_ARGS__);\
| ^~~~~~~~~
thermal_interrupt_events.c:186:25: note: in expansion of macro
‘tst_res’
186 | tst_res(TFAIL, "CPU %d interrupt
counter: %llu (previous: %llu)",
| ^~~~~~~
>
> > + }
> > +
> > + if (status)
>
> I'm not sure about status variable. Most of the information are
> static
> and can be seen here as well.
Removed.
>
> > + tst_res(TPASS, "x86 package thermal interrupt
> > triggered");
> > +}
> > +
> > +static struct tst_test test = {
> > + .cleanup = cleanup,
> > + .forks_child = 1,
> > + .min_runtime = 180,
> > + .needs_root = 1,
> > + .setup = setup,
> > + .supported_archs = (const char *const []) {
> > + "x86",
> > + "x86_64",
> > + NULL
> > + },
> > + .test_all = run
> > +};
>
>
> There's not .gitignore entry for binary once binary is produced.
Ah, I missed that because the file is obviously hidden, thanks.
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
More information about the ltp
mailing list