[LTP] [PATCH v2 1/6] doc: INSTALL: dma_thread_diotest.c: Remove runltp from doc
Enji Cooper (yaneurabeya)
yaneurabeya@gmail.com
Sun Feb 22 21:26:45 CET 2026
> On Feb 22, 2026, at 12:21 PM, Petr Vorel <pvorel@suse.cz> wrote:
>
>> Hi!
>>>>>>> @@ -105,9 +105,9 @@ Quick Start
>>>>>>> $ ./configure
>>>>>>> $ make all
>>>>>>> # make install
>>>>>> ^
>>>>>> This should be $ (not caused by this patch but worth fixing)
>
>>>>> I can change it, but IMHO for creating /opt/ltp is needed to run it as root
>>>>> for a first time. Or one must chmod/chown /opt/ltp under root.
>
>>>> Huh? The make install should just work fine. I'm just pointing out the
>>>> typo # vs $. Or did I miss something?
>
>>> Yeah, I understand it and plan to change # => $. I talked about /opt (our
>>> default prefix) usually not being writable by regular users (installing any
>>> software using standard system prefix will have this problem). Root is needed
>>> only for creating /opt/ltp. That was the reason for the original user to use '#'.
>>> But as I wrote, I'm ok to change the prompt.
>
>> Ah, that's a bit confusing then because in shell script # is a comment.
>> I usually prefix commands that needs root with sudo instead. So what
>> about "$ sudo make install" ?
>
> +1, good point.
> I'll merge whole patchset with this change tomorrow.
Using markdown and sudo would make it unambiguous. I’m not sure if markdown makes sense here, but at the very least I would reference sudo or made the directions explicitly state that the command must be run as root.
Just my 2 cents...
-Enji
Example:
```bash
$ ./configure
$ make all
$ sudo make install
```
More information about the ltp
mailing list