[LTP] [PATCH 1/2] open: remove O_DIRECTORY case (move to fstat test)
Jinseok Kim
always.starving0@gmail.com
Tue Feb 24 08:37:24 CET 2026
The O_DIRECTORY test case was mostly verifying fstat() behavior on an
existing directory rather than testing any specific open() behavior.
Following review suggestion, remove it from open01.c. A separate fstat
test will be added in a follow-up patch to cover file type checks
(S_ISDIR, etc.) more comprehensively.
Signed-off-by: Jinseok Kim <always.starving0@gmail.com>
---
testcases/kernel/syscalls/open/open01.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/testcases/kernel/syscalls/open/open01.c b/testcases/kernel/syscalls/open/open01.c
index baf73ab11..801859e68 100644
--- a/testcases/kernel/syscalls/open/open01.c
+++ b/testcases/kernel/syscalls/open/open01.c
@@ -8,16 +8,12 @@
/*
* DESCRIPTION
* Open a file with oflag = O_CREAT set, does it set the sticky bit off?
- * Open a dir with O_DIRECTORY, does it set the S_IFDIR bit on?
*
* ALGORITHM
* 1. open a new file with O_CREAT, fstat.st_mode should not have the
* 01000 bit on. In Linux, the save text bit is *NOT* cleared.
- * 2. open a new dir with O_DIRECTORY, fstat.st_mode should have the
- * 040000 bit on.
*/
-#define _GNU_SOURCE /* for O_DIRECTORY */
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
@@ -25,7 +21,6 @@
#include "tst_test.h"
#define TEST_FILE "testfile"
-#define TEST_DIR "testdir"
static int fd;
@@ -37,7 +32,6 @@ static struct tcase {
char *desc;
} tcases[] = {
{TEST_FILE, O_RDWR | O_CREAT, 01444, S_ISVTX, "sticky bit"},
- {TEST_DIR, O_DIRECTORY, 0, S_IFDIR, "sirectory bit"}
};
static void verify_open(unsigned int n)
--
2.43.0
More information about the ltp
mailing list