[LTP] [PATCH v3 2/2] fstat: add test for multiple file types using fstat

Andrea Cervesato andrea.cervesato@suse.com
Thu Feb 26 16:44:19 CET 2026


Hi,

On Thu Feb 26, 2026 at 4:32 PM CET, Jinseok Kim wrote:
> Hi,
>
> Thank you for the review.
>
> If we switch to using lstat() only, this test would no longer exercise
> fstat() at all, which changes the original intent of the test.
>
> In that case, should we consider renaming the test from fstat to lstat?
>
> Jinseok.

Sorry for the confusion...of course. The point is if we want to test
inode macros or fstat(), and of course we want to test fstat().
According to that, we should correctly use the syscall. For instance,
when using fstat():

fstat04.c:63: TFAIL: symbolic link: S_IFLNK() macro does NOT match
fstat04.c:45: TBROK: open(chrdev,2048,0000) failed: EACCES (13)

And this has to be fixed of course.

-- 
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com



More information about the ltp mailing list