[LTP] [PATCH v6 1/4] lib: Add support option for .needs_cmds

[Cyril Hrubis]

Hi!
> +enum cmd_ids {
> +	CMD,
> +	OPTIONAL,
> +	PRESENT,
> +};
> +
> +static ujson_obj_attr cmd_attrs[] = {
> +	UJSON_OBJ_ATTR_IDX(CMD, "cmd", UJSON_STR),
> +	UJSON_OBJ_ATTR_IDX(OPTIONAL, "optional", UJSON_INT),
> +	UJSON_OBJ_ATTR_IDX(PRESENT, "present", UJSON_INT),

I do not think that we should add the present attribute to the shell
parser, that attribute should never be set by the test and is set by the
shell library.


The rest looks good.

With the "present" attribute removed from the json parser:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz