[LTP] [PATCHv2] listmount04.c: update struct mnt_id_req support to kernel >= 6.17.9
Po-Hsu Lin
po-hsu.lin@canonical.com
Thu Jan 8 16:45:47 CET 2026
On Thu, 8 Jan 2026 at 20:13, Petr Vorel <pvorel@suse.cz> wrote:
> Hi Po-Hsu Lin,
>
> > The kernel change 78f0e33cd6c93 ("fs/namespace: correctly handle errors
> > returned by grab_requested_mnt_ns") from 6.18 has been ported to upstream
> > 6.17.9 [1][2].
>
> > Therefore change the expectation from >= 6.18 to >= 6.17.9 accodingly.
>
> > [1] https://lwn.net/Articles/1047684/
> > [2]
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.17.9&id=8ff97ade
>
> > v2: add comments for this change into the code.
>
> > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> > ---
> > .../kernel/syscalls/listmount/listmount04.c | 18 +++++++++++-------
> > 1 file changed, 11 insertions(+), 7 deletions(-)
>
> > diff --git a/testcases/kernel/syscalls/listmount/listmount04.c
> b/testcases/kernel/syscalls/listmount/listmount04.c
> > index 2b8b49101..59da46cfd 100644
> > --- a/testcases/kernel/syscalls/listmount/listmount04.c
> > +++ b/testcases/kernel/syscalls/listmount/listmount04.c
> > @@ -7,6 +7,10 @@
> > * Verify that listmount() raises the correct errors according with
> > * invalid data:
> > *
> > + * - EBADF: invalid mnt_ns_fd
> > + * This check was introduced for kernel commit 78f0e33cd6c9
> ("fs/namespace:
> > + * correctly handle errors returned by grab_requested_mnt_ns")
> introduced
> > + * in v6.18-rc7 and backported to v6.17.9.
>
> TL;DR
> Please either fix RST syntax or move text outside /*\ section.
>
> IMHO this is an implementation detail, I don't think we need it in the test
> catalog docs [1]. I would just put this comment above macro definition:
> #define
> BEFORE_6_17_9 1.
>
> Also this is a wrong RST syntax. FYI we parse this into sphinx docs [1] and
> this breaks formatting of the list:
>
> * EBADF: invalid mnt_ns_fd
>
> This check was introduced for kernel commit 78f0e33cd6c9 (“fs/namespace:
> correctly handle errors returned by grab_requested_mnt_ns”) introduced in
> v6.18-rc7 and backported to v6.17.9. - EFAULT: req or mnt_id are
> unaccessible memories - EINVAL: invalid flags or mnt_id request - ENOENT:
> non-existent mount point
>
> If you run:
> $ cd doc; make setup && make
>
> you'll get local build of the documentation, see
> ./html/users/test_catalog.html#listmount04
>
> Cool!
thanks for the information, I will correct this and send another version.
> Kind regards,
> Petr
>
> [1]
> file:///home/pevik/install/src/ltp.git/doc/html/users/test_catalog.html#listmount04
>
More information about the ltp
mailing list