[LTP] [PATCH] hugetlb: migrate library and numa helpers to libs/

[Li Wang]

Pradeep Susarla <pradeep.susarla@gmail.com> wrote:


>  .../lib/hugetlb.h => include/tst_hugetlb.h    |  8 +-

This would be better named "libhugetlb.h", anything under the ltp/libs/*
should not have a prefix 'tst_' to distinguish the main LTP API.

Otherwise, people may be confused about tst_hugepage.h tst_hugetlb.h
and can't find the '*.c' achieved file in ltp/lib/.

>  include/tst_numa.h                            |  9 +++

Rename to libnuma.h.

There are some other libs/tst_*.c that should be renamed to prefix lib*,
but yes, this is not related to your patch.

>  libs/hugetlb/Makefile                         |  8 ++
>  .../hugetlb.c => libs/hugetlb/libhugetlb.c    | 10 +--
>  libs/numa/tst_numa.c                          | 79 ++++++++++++++++---
>  testcases/kernel/include/numa_helper.h        |  2 +-
>  testcases/kernel/lib/numa_cpuset.c            | 64 ---------------
>  testcases/kernel/mem/hugetlb/Makefile         | 28 ++-----
>  testcases/kernel/mem/hugetlb/Makefile.inc     | 24 +++---
...
>  testcases/kernel/mem/hugetlb/lib/Makefile     | 10 ---

>  testcases/kernel/mem/ksm/ksm02.c              |  5 +-

ksm02.c compile failed on CentOS 10 x86_64.


--
Regards,
Li Wang