[LTP] test_macros: Add TST_EXP_PASS_OR_FAIL()

linuxtestproject.agent@gmail.com linuxtestproject.agent@gmail.com
Fri Jul 10 13:55:21 CEST 2026


Hi Petr,

On Fri, Jul 10, 2026, Petr Vorel wrote:
> test_macros: Add TST_EXP_PASS_OR_FAIL()

> + Fix macro parameter name in TST_EXP_FD_OR_FAIL() (upper case).

This is a second, independent logical change bundled into the same
patch. Ground Rule 7 requires exactly one logical change per patch.
The doc-comment fix in TST_EXP_FD_OR_FAIL() should go in a separate
preparatory patch.

> + * TST_EXP_PASS_OR_FAIL() - Test syscall to and expect to pass or fail with
> + * expected errno.

"to and expect" reads as ungrammatical here. Something like:

  TST_EXP_PASS_OR_FAIL() - Test syscall to pass or fail with expected errno.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer


More information about the ltp mailing list