[LTP] lapi: Add pkt_cls.h fallback
Andrea Cervesato
andrea.cervesato@suse.com
Thu Jul 16 10:36:30 CEST 2026
Hi Cyril,
> Hi!
> > > +/*
> > > + * Same as NETDEV_REMOVE_QDISC() but does not fail when the qdisc is
> > > + * missing (strict=0), so it can be used to clear a possibly absent qdisc.
> > > + */
> > > +#define NETDEV_MAY_REMOVE_QDISC(ifname, family, parent, handle, qd_kind) \
> >
> > New public macros in include/ require kernel-doc (/** */), not a plain
> > block comment. The content is fine; it just needs the right opener:
> >
> > /**
> > * NETDEV_MAY_REMOVE_QDISC - remove qdisc without failing if absent.
> > * @ifname: network interface name
> > * @family: address family
> > * @parent: parent handle
> > * @handle: qdisc handle
> > * @qd_kind: qdisc kind string
> > *
> > * Same as NETDEV_REMOVE_QDISC() but passes strict=0, so it does not
> > * fail when the qdisc is missing.
> > */
>
> Looks reasonable. It may be a good idea to copy&paste this to the header
> before applying the patch.
But then we should do it for all the others as well, maybe we should have
a follow up patch to document all macros instead.
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
More information about the ltp
mailing list