[LTP] gitignore: ignore ltp-agent setup files

linuxtestproject.agent@gmail.com linuxtestproject.agent@gmail.com
Mon Jun 1 11:39:46 CEST 2026


Hi Andrea,

On Mon, 01 Jun 2026 08:46:10 +0200, Andrea Cervesato wrote:
> gitignore: ignore ltp-agent setup files

Infrastructure-only patch (`.gitignore` only) — code review checklist
skipped per protocol.

COMMIT MESSAGE
--------------
The subject follows <area>: <description> format with imperative mood.

The body accurately enumerates the injected artefacts: AGENTS.md, GEMINI.md,
.agents, .claude, and the agents/, linter/, skills/ symlinks.

The rationale for root-anchoring /agents, /linter, and /skills with a
leading '/' and no trailing slash is correct:
  - Leading '/' prevents shadowing same-named subdirectories deeper in the
    tree (e.g. a hypothetical testcases/foo/agents/).
  - Omitting the trailing slash is necessary because these are symlinks; a
    trailing slash in .gitignore only matches real directories, not symlinks,
    so the entries would silently fail to suppress them without it.

/.pi/ correctly uses both a root anchor and a trailing slash (actual
directory, not a symlink).

PATCH CORRECTNESS
-----------------
All nine added entries map 1:1 to the artefacts described in the body.
The two comment headers ("# ltp-agent setup" and "# agents files") cleanly
separate the injected runtime artefacts from the scratch working files.

The unanchored entries (.agents, .claude, review-inline.txt, AGENTS.md,
GEMINI.md) lack a leading '/'. This makes them match anywhere in the tree,
not just at the root. For .agents and .claude this is a slight overshoot
compared to the anchored treatment of /agents, /linter, /skills, but the
commit body does not claim these are anchored. In practice, no test code
creates .agents or .claude subdirectories, so no false suppression is
expected. This is noted for completeness but does not require a fix.

Verdict: Reviewed ✓

Reviewed-by: LTP AI Reviewer <ltp-ai@ltp.example.com>

LTP AI Reviewer


More information about the ltp mailing list