[LTP] doc: Add missing API references to api_c_tests.rst
Andrea Cervesato
andrea.cervesato@suse.com
Fri Jun 5 11:39:24 CEST 2026
Hi,
>
> > Fixes: eef750db28 ("libs: adopt tse_ prefix for extended (non-core) library")
>
> The Fixes tag references a commit that does not exist in the git
> history. `git cat-file -t eef750db28` returns "Not a valid object
> name". Either the hash is wrong or the tag should be dropped.
>
This is caused by the CI. I need to fix it.
> --- [PATCH 2/3] ---
>
> > * - .needs_device
> > - TST_NEEDS_DEVICE
> >
> > + * - .needs_hugetlbfs
> > + - \-
> > +
> > * - removed
> > - TST_NEEDS_DRIVERS
>
> The `removed` row corresponds to the formerly-named `.needs_drivers`
> field. Alphabetically `needs_drivers` (d) sorts before
> `needs_hugetlbfs` (h), so the `removed` row should appear before
> `.needs_hugetlbfs`, not after it.
This is valid.
>
> > Add 8 missing struct tst_test fields to the C/Shell API comparison
> > table in writing_tests.rst: ...
> >
> > Add a shell API variables reference section to api_shell_tests.rst
>
> Two independent changes are bundled here: updating the comparison
> table in writing_tests.rst and adding the "Shell API variables"
> section to api_shell_tests.rst. These touch different files and serve
> different purposes. Each should be a separate commit per ground rule 7
> (one logical change per patch).
>
> --- [PATCH 3/3] ---
>
> > - ``SAFE_FILE_READ_STR(path, buf)``
>
> The macro is declared in include/tst_safe_file_ops.h as:
>
> #define SAFE_FILE_READ_STR(path, buf, buf_size)
>
> It takes three arguments, not two. The `buf_size` parameter is
> missing from the listed signature.
This is also valid.
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
More information about the ltp
mailing list