[LTP] connect01: Convert to new API

linuxtestproject.agent@gmail.com linuxtestproject.agent@gmail.com
Tue Jun 16 10:35:24 CEST 2026


Hi Wei,

On Tue, Jun 16, 2026, Wei Gao wrote:
> connect01: Convert to new API

--- [PATCH 2/2] ---

> +	.needs_root = 1,

Ground Rule 4 requires the doc comment to explain why root is
needed. The EACCES case drops to nobody via SAFE_SETUID, which
requires starting as root. Could the doc block mention this?

For example:

  /*\
   * Verify that :manpage:`connect(2)` returns the proper errno
   * for various failure cases.
   *
   * Requires root to test EACCES by dropping privileges to an
   * unprivileged user.
   */

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer


More information about the ltp mailing list