[LTP] rfim: add new test for verifying RFIM sysfs interface
linuxtestproject.agent@gmail.com
linuxtestproject.agent@gmail.com
Mon Jun 22 11:59:56 CEST 2026
Hi Piotr,
On Mon, 22 Jun 2026, Piotr Kubaj wrote:
> rfim: add new test for verifying RFIM sysfs interface
> +#define RFIM_ROOT "/sys/bus/pci/devices/0000:00:04.0"
The PCI BDF 0000:00:04.0 is hardcoded. While this is the common
address for the proc_thermal device on Intel client platforms, it is
not universal -- multi-die systems or future SOCs could place it
elsewhere.
The test gracefully TCONFs when the path is absent, but it also
silently skips on systems that DO have RFIM at a different BDF.
Could this discover the device dynamically instead, for example by
walking /sys/bus/pci/drivers/proc_thermal_pci/ to find the bound
device?
> +static const char * const rw_dvfs_nodes[] = {
> + RFIM_ROOT "/dvfs/rfi_restriction_run_busy",
> + RFIM_ROOT "/dvfs/rfi_restriction_err_code",
> + RFIM_ROOT "/dvfs/rfi_restriction_data_rate_base",
> + RFIM_ROOT "/dvfs/rfi_restriction_data_rate",
> + NULL
> +};
The kernel's dvfs group also exposes rfi_disable (RW), ddr_data_rate
(RO), and rfi_restriction (RW). Any reason these are excluded?
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
More information about the ltp
mailing list